From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1pITh1-0002bA-2D for mharc-qemu-riscv@gnu.org; Thu, 19 Jan 2023 07:06:55 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pITgv-0002Ds-FS; Thu, 19 Jan 2023 07:06:50 -0500 Received: from kylie.crudebyte.com ([5.189.157.229]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pITgt-0002O6-7V; Thu, 19 Jan 2023 07:06:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=crudebyte.com; s=kylie; h=Content-Type:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Content-ID:Content-Description; bh=ohnYTkiG/JEnv7BTDnK67k+U1CDGbji+raBagx15Bhc=; b=ehCBkc+1OZ3ygLgkNvISH0vbQ/ RCKE1D+TmgKfJum6DYs9Vg3NKUr4LOXaKw0x37whdUu3/TH1uKzgqNb2jsTb5oFqLD5IPZeIc/P7i yruP6WpZG2NgFLDJ9gwHQ00Bdql558BQRCvQvlYIChjuoC/kL2hgrgEG76+WSaaammMna+7YkTI+q 6z1bWUaBXOrgWx92VzWAwwbjnAhSXB1bwqYrfvnZ59oHGL8Ooq4t63o94NN8ABHJfpMKxROe+4e6h JtWT5CoorNvT18Edr/GCfwIwNmoiHM3t35PScu3FXMELkAD19J3L+9uzzBN0upQR/i1om4FQjUwiQ rF2cnuA9VYWZgfHltl+O2T3H6cPXegIfIusGokocz9ak+Wq2RN9uCd8SMTU8l8uo2sNQOiav4K5Sl xqoIHluBkVTUeyzdmLEgeBkRTBxGUVcHVEgjX4EuRx1aoyHbDmSTgOm3nMRXcx549B2LYvR63DzMq s/nZgmunrxxXntqG9dcvoldVleRcnlFfeM6fd5su6WZEdnELXkoFR283GV09JNPUWXpKuNtsFdJw2 OIxi8ZPiTfRx8zY+EgLpT4HUaZ+W1IiXp77xgjzmY3gG3e//ZOZWvoy7OFdQLdVVznRK2anBYYsRL CODhpmv/fjurBzuhz1RTHAQq/4sKylTJZIg5XOArA=; From: Christian Schoenebeck To: qemu-devel@nongnu.org Cc: richard.henderson@linaro.org, pbonzini@redhat.com, kwolf@redhat.com, hreitz@redhat.com, imp@bsdimp.com, kevans@freebsd.org, berrange@redhat.com, groug@kaod.org, mst@redhat.com, philmd@linaro.org, peter.maydell@linaro.org, alistair@alistair23.me, jasowang@redhat.com, jonathan.cameron@huawei.com, kbastian@mail.uni-paderborn.de, quintela@redhat.com, dgilbert@redhat.com, michael.roth@amd.com, kkostiuk@redhat.com, tsimpson@quicinc.com, palmer@dabbelt.com, bin.meng@windriver.com, qemu-block@nongnu.org, qemu-arm@nongnu.org, qemu-riscv@nongnu.org, Markus Armbruster Subject: Re: [PATCH v4 17/19] Don't include headers already included by qemu/osdep.h Date: Thu, 19 Jan 2023 13:06:26 +0100 Message-ID: <12588900.kcvoAOTtsJ@silver> In-Reply-To: <20230119065959.3104012-18-armbru@redhat.com> References: <20230119065959.3104012-1-armbru@redhat.com> <20230119065959.3104012-18-armbru@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Received-SPF: pass client-ip=5.189.157.229; envelope-from=qemu_oss@crudebyte.com; helo=kylie.crudebyte.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-riscv@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Jan 2023 12:06:53 -0000 On Thursday, January 19, 2023 7:59:57 AM CET Markus Armbruster wrote: > This commit was created with scripts/clean-includes. > > Signed-off-by: Markus Armbruster > --- For 9p changes: Acked-by: Christian Schoenebeck > backends/tpm/tpm_ioctl.h | 2 -- > fsdev/p9array.h | 2 -- > include/hw/misc/aspeed_lpc.h | 2 -- > include/hw/pci/pcie_doe.h | 1 - > include/qemu/async-teardown.h | 2 -- > include/qemu/dbus.h | 1 - > include/qemu/host-utils.h | 1 - > include/sysemu/event-loop-base.h | 1 - > accel/tcg/cpu-exec.c | 1 - > hw/9pfs/9p.c | 2 -- > hw/display/virtio-gpu-udmabuf.c | 1 - > hw/i2c/pmbus_device.c | 1 - > hw/remote/proxy-memory-listener.c | 1 - > hw/sensor/adm1272.c | 1 - > hw/usb/dev-storage-bot.c | 1 - > hw/usb/dev-storage-classic.c | 1 - > softmmu/vl.c | 2 -- > tcg/tci.c | 1 - > tests/unit/test-seccomp.c | 1 - > ui/udmabuf.c | 1 - > util/main-loop.c | 1 - > util/oslib-posix.c | 2 -- > 22 files changed, 29 deletions(-) > > diff --git a/backends/tpm/tpm_ioctl.h b/backends/tpm/tpm_ioctl.h > index e506ef5160..b1d31768a6 100644 > --- a/backends/tpm/tpm_ioctl.h > +++ b/backends/tpm/tpm_ioctl.h > @@ -12,8 +12,6 @@ > # define __USE_LINUX_IOCTL_DEFS > #endif > > -#include > -#include > #ifndef _WIN32 > #include > #include > diff --git a/fsdev/p9array.h b/fsdev/p9array.h > index 90e83a7c7b..50a1b15fe9 100644 > --- a/fsdev/p9array.h > +++ b/fsdev/p9array.h > @@ -27,8 +27,6 @@ > #ifndef QEMU_P9ARRAY_H > #define QEMU_P9ARRAY_H > > -#include "qemu/compiler.h" > - > /** > * P9Array provides a mechanism to access arrays in common C-style (e.g. by > * square bracket [] operator) in conjunction with reference variables that > diff --git a/include/hw/misc/aspeed_lpc.h b/include/hw/misc/aspeed_lpc.h > index fd228731d2..fa398959af 100644 > --- a/include/hw/misc/aspeed_lpc.h > +++ b/include/hw/misc/aspeed_lpc.h > @@ -12,8 +12,6 @@ > > #include "hw/sysbus.h" > > -#include > - > #define TYPE_ASPEED_LPC "aspeed.lpc" > #define ASPEED_LPC(obj) OBJECT_CHECK(AspeedLPCState, (obj), TYPE_ASPEED_LPC) > > diff --git a/include/hw/pci/pcie_doe.h b/include/hw/pci/pcie_doe.h > index ba4d8b03bd..87dc17dcef 100644 > --- a/include/hw/pci/pcie_doe.h > +++ b/include/hw/pci/pcie_doe.h > @@ -11,7 +11,6 @@ > #define PCIE_DOE_H > > #include "qemu/range.h" > -#include "qemu/typedefs.h" > #include "hw/register.h" > > /* > diff --git a/include/qemu/async-teardown.h b/include/qemu/async-teardown.h > index 092e7a37e7..b281da005b 100644 > --- a/include/qemu/async-teardown.h > +++ b/include/qemu/async-teardown.h > @@ -13,8 +13,6 @@ > #ifndef QEMU_ASYNC_TEARDOWN_H > #define QEMU_ASYNC_TEARDOWN_H > > -#include "config-host.h" > - > #ifdef CONFIG_LINUX > void init_async_teardown(void); > #endif > diff --git a/include/qemu/dbus.h b/include/qemu/dbus.h > index 08f00dfd53..81d3de8a5a 100644 > --- a/include/qemu/dbus.h > +++ b/include/qemu/dbus.h > @@ -15,7 +15,6 @@ > #include "qom/object.h" > #include "chardev/char.h" > #include "qemu/notify.h" > -#include "qemu/typedefs.h" > > /* glib/gio 2.68 */ > #define DBUS_METHOD_INVOCATION_HANDLED TRUE > diff --git a/include/qemu/host-utils.h b/include/qemu/host-utils.h > index 88d476161c..3ce62bf4a5 100644 > --- a/include/qemu/host-utils.h > +++ b/include/qemu/host-utils.h > @@ -30,7 +30,6 @@ > #ifndef HOST_UTILS_H > #define HOST_UTILS_H > > -#include "qemu/compiler.h" > #include "qemu/bswap.h" > #include "qemu/int128.h" > > diff --git a/include/sysemu/event-loop-base.h b/include/sysemu/event-loop-base.h > index 2748bf6ae1..a6c24f1351 100644 > --- a/include/sysemu/event-loop-base.h > +++ b/include/sysemu/event-loop-base.h > @@ -14,7 +14,6 @@ > > #include "qom/object.h" > #include "block/aio.h" > -#include "qemu/typedefs.h" > > #define TYPE_EVENT_LOOP_BASE "event-loop-base" > OBJECT_DECLARE_TYPE(EventLoopBase, EventLoopBaseClass, > diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c > index 8927092537..dd8f54a415 100644 > --- a/accel/tcg/cpu-exec.c > +++ b/accel/tcg/cpu-exec.c > @@ -28,7 +28,6 @@ > #include "exec/exec-all.h" > #include "tcg/tcg.h" > #include "qemu/atomic.h" > -#include "qemu/compiler.h" > #include "qemu/timer.h" > #include "qemu/rcu.h" > #include "exec/log.h" > diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c > index 072cf67956..9621ec1341 100644 > --- a/hw/9pfs/9p.c > +++ b/hw/9pfs/9p.c > @@ -19,8 +19,6 @@ > #include "qemu/osdep.h" > #ifdef CONFIG_LINUX > #include > -#else > -#include > #endif > #include > #include "hw/virtio/virtio.h" > diff --git a/hw/display/virtio-gpu-udmabuf.c b/hw/display/virtio-gpu-udmabuf.c > index 8bdf4bac6e..847fa4c0cc 100644 > --- a/hw/display/virtio-gpu-udmabuf.c > +++ b/hw/display/virtio-gpu-udmabuf.c > @@ -21,7 +21,6 @@ > #include "exec/ramblock.h" > #include "sysemu/hostmem.h" > #include > -#include > #include > #include "qemu/memfd.h" > #include "standard-headers/linux/udmabuf.h" > diff --git a/hw/i2c/pmbus_device.c b/hw/i2c/pmbus_device.c > index 4071a88cfc..c3d6046784 100644 > --- a/hw/i2c/pmbus_device.c > +++ b/hw/i2c/pmbus_device.c > @@ -8,7 +8,6 @@ > > #include "qemu/osdep.h" > #include > -#include > #include "hw/i2c/pmbus_device.h" > #include "migration/vmstate.h" > #include "qemu/module.h" > diff --git a/hw/remote/proxy-memory-listener.c b/hw/remote/proxy-memory-listener.c > index eb9918fe72..18d96a1d04 100644 > --- a/hw/remote/proxy-memory-listener.c > +++ b/hw/remote/proxy-memory-listener.c > @@ -8,7 +8,6 @@ > > #include "qemu/osdep.h" > > -#include "qemu/compiler.h" > #include "qemu/int128.h" > #include "qemu/range.h" > #include "exec/memory.h" > diff --git a/hw/sensor/adm1272.c b/hw/sensor/adm1272.c > index 7310c769be..8f4a1c2cd4 100644 > --- a/hw/sensor/adm1272.c > +++ b/hw/sensor/adm1272.c > @@ -8,7 +8,6 @@ > */ > > #include "qemu/osdep.h" > -#include > #include "hw/i2c/pmbus_device.h" > #include "hw/irq.h" > #include "migration/vmstate.h" > diff --git a/hw/usb/dev-storage-bot.c b/hw/usb/dev-storage-bot.c > index b24b3148c2..1e5c5c711f 100644 > --- a/hw/usb/dev-storage-bot.c > +++ b/hw/usb/dev-storage-bot.c > @@ -8,7 +8,6 @@ > */ > > #include "qemu/osdep.h" > -#include "qemu/typedefs.h" > #include "qapi/error.h" > #include "hw/usb.h" > #include "hw/usb/desc.h" > diff --git a/hw/usb/dev-storage-classic.c b/hw/usb/dev-storage-classic.c > index 00f25bade2..84d19752b5 100644 > --- a/hw/usb/dev-storage-classic.c > +++ b/hw/usb/dev-storage-classic.c > @@ -8,7 +8,6 @@ > */ > > #include "qemu/osdep.h" > -#include "qemu/typedefs.h" > #include "qapi/error.h" > #include "qapi/visitor.h" > #include "hw/usb.h" > diff --git a/softmmu/vl.c b/softmmu/vl.c > index 9177d95d4e..5355a7fe5a 100644 > --- a/softmmu/vl.c > +++ b/softmmu/vl.c > @@ -136,8 +136,6 @@ > #include "qemu/guest-random.h" > #include "qemu/keyval.h" > > -#include "config-host.h" > - > #define MAX_VIRTIO_CONSOLES 1 > > typedef struct BlockdevOptionsQueueEntry { > diff --git a/tcg/tci.c b/tcg/tci.c > index 05a24163d3..e7ac74cab0 100644 > --- a/tcg/tci.c > +++ b/tcg/tci.c > @@ -21,7 +21,6 @@ > #include "exec/cpu_ldst.h" > #include "tcg/tcg-op.h" > #include "tcg/tcg-ldst.h" > -#include "qemu/compiler.h" > #include > > > diff --git a/tests/unit/test-seccomp.c b/tests/unit/test-seccomp.c > index 3d7771e46c..f02c79cafd 100644 > --- a/tests/unit/test-seccomp.c > +++ b/tests/unit/test-seccomp.c > @@ -25,7 +25,6 @@ > #include "qapi/error.h" > #include "qemu/module.h" > > -#include > #include > > static void test_seccomp_helper(const char *args, bool killed, > diff --git a/ui/udmabuf.c b/ui/udmabuf.c > index cebceb2610..cbf4357bb1 100644 > --- a/ui/udmabuf.c > +++ b/ui/udmabuf.c > @@ -8,7 +8,6 @@ > #include "qapi/error.h" > #include "ui/console.h" > > -#include > #include > > int udmabuf_fd(void) > diff --git a/util/main-loop.c b/util/main-loop.c > index 58f776a8c9..3c0f525192 100644 > --- a/util/main-loop.c > +++ b/util/main-loop.c > @@ -33,7 +33,6 @@ > #include "block/thread-pool.h" > #include "qemu/error-report.h" > #include "qemu/queue.h" > -#include "qemu/compiler.h" > #include "qom/object.h" > > #ifndef _WIN32 > diff --git a/util/oslib-posix.c b/util/oslib-posix.c > index 59a891b6a8..fd03fd32c8 100644 > --- a/util/oslib-posix.c > +++ b/util/oslib-posix.c > @@ -40,7 +40,6 @@ > #include "qemu/thread.h" > #include > #include "qemu/cutils.h" > -#include "qemu/compiler.h" > #include "qemu/units.h" > #include "qemu/thread-context.h" > > @@ -50,7 +49,6 @@ > > #ifdef __FreeBSD__ > #include > -#include > #include > #include > #endif >