From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1NDOci-0001GH-8X for mharc-grub-devel@gnu.org; Wed, 25 Nov 2009 15:38:00 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NDOcg-0001Dr-9r for grub-devel@gnu.org; Wed, 25 Nov 2009 15:37:58 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NDOcb-00018D-Ma for grub-devel@gnu.org; Wed, 25 Nov 2009 15:37:57 -0500 Received: from [199.232.76.173] (port=49592 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NDOcb-00017p-4Q for grub-devel@gnu.org; Wed, 25 Nov 2009 15:37:53 -0500 Received: from moutng.kundenserver.de ([212.227.17.9]:64615) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NDOca-0003Pk-GX for grub-devel@gnu.org; Wed, 25 Nov 2009 15:37:52 -0500 Received: from [85.180.5.7] (e180005007.adsl.alicedsl.de [85.180.5.7]) by mrelayeu.kundenserver.de (node=mrbap0) with ESMTP (Nemesis) id 0MQM5U-1NabPV091A-00UIyy; Wed, 25 Nov 2009 21:37:49 +0100 From: Felix Zielcke To: The development of GRUB 2 Content-Type: text/plain; charset="UTF-8" Date: Wed, 25 Nov 2009 21:37:47 +0100 Message-ID: <1259181468.2806.15.camel@fz.local> Mime-Version: 1.0 X-Mailer: Evolution 2.29.2 Content-Transfer-Encoding: 7bit X-Provags-ID: V01U2FsdGVkX1/m9uJBoLczZcY/5Gt7IxonSZtGKim2ssU15rJ L9JYO/cGlICXle+eRN22NwWDXVIDqng0Nx1jhZjtQQXjI+dbNz KigBE9nRGNChsQ6J5JtFuD4KAUYQ3vT X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: grub_halt() X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Nov 2009 20:37:58 -0000 grub_halt is on i386-pc defined as `void grub_halt (int no_apm)' but everywhere else as `grub_halt (void)' util/grub-emu.c has a #ifdef for these 2 Shouldn't we just add an int parameter everywhere to make this more simple? grub-emu fails to build on powerpc now because grub/cpu/halt.h doestn't exist there: https://buildd.debian.org/fetch.cgi?pkg=grub2;ver=1.97%2B20091125-1;arch=powerpc;stamp=1259179180 -- Felix Zielcke Proud Debian Maintainer and GNU GRUB developer