All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zhu Yi <yi.zhu@intel.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: "linville@tuxdriver.com" <linville@tuxdriver.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [RFC 1/2] wireless: add ieee80211_asmdu_to_8023s
Date: Fri, 27 Nov 2009 17:30:17 +0800	[thread overview]
Message-ID: <1259314217.12157.3.camel@debian> (raw)
In-Reply-To: <1259313653.5428.5.camel@johannes.local>

On Fri, 2009-11-27 at 17:20 +0800, Johannes Berg wrote:
> Is it? I don't think so. Many drivers go up beyond that as far as I
> know. Then some do different things like putting it in a different DMA
> block.
> 
> > While for those drivers really need a bigger
> > extra headroom and support Rx aggregation, this probably means
> > ieee80211_skb_resize. But the resize should always happen for every
> > packet from the IP stack, right?
> 
> No, davem and I optimised that away a long time ago via using
> netdev->needed_headroom and netdev->needed_tailroom. It even works for
> bridges and their slave devices, iirc. 

I missed this. Will check it. If so, I'll add another parameter to pass
the extra hw tx headroom to ieee80211_asmdu_to_8023s.

Thanks,
-yi


  reply	other threads:[~2009-11-27  9:30 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-26  6:03 [RFC 1/2] wireless: add ieee80211_asmdu_to_8023s Zhu Yi
2009-11-26  6:03 ` [RFC 2/2] iwmc3200wifi: rx aggregation support Zhu Yi
2009-11-26  9:49 ` [RFC 1/2] wireless: add ieee80211_asmdu_to_8023s Johannes Berg
2009-11-27  1:06   ` Zhu Yi
2009-11-27  9:18     ` Johannes Berg
2009-11-26 10:05 ` Johannes Berg
2009-11-27  2:52   ` Zhu Yi
2009-11-27  9:20     ` Johannes Berg
2009-11-27  9:30       ` Zhu Yi [this message]
2009-11-27  9:33         ` Johannes Berg
2009-11-27  9:35           ` Johannes Berg
2009-11-30  2:34         ` Zhu Yi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1259314217.12157.3.camel@debian \
    --to=yi.zhu@intel.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.