From: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
To: "Török Edwin" <edwintorok@gmail.com>
Cc: Dave Jones <davej@redhat.com>,
Mauro Carvalho Chehab <mchehab@redhat.com>,
Greg Kroah-Hartman <gregkh@suse.de>,
Linux Kernel <linux-kernel@vger.kernel.org>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: Memset of length zero bugs
Date: Fri, 27 Nov 2009 17:04:02 +0200 [thread overview]
Message-ID: <1259334242.7518.31.camel@localhost> (raw)
In-Reply-To: <4B0E6189.6050708@gmail.com>
On Thu, 2009-11-26 at 13:07 +0200, Török Edwin wrote:
... snip ...
> inlined from ‘crosstest’ at drivers/mtd/tests/mtd_pagetest.c:219:
> /home/edwin/builds/linux-2.6/arch/x86/include/asm/string_64.h:61:
> warning: call to ‘__warn_memset_zero_len’ declared with attribute
> warning: memset used with constant zero length parameter; this could be
> due to transposed parameters
>
> Now this one is interesting, the memsets are fine, however pgsize is
> always zero, it is declared as 'static int pgsize' and never assigned a
> value (hence it is always zero).
> I didn't look at what mtd_pagetest wants to test, but the name suggests
> that a pagesize of zero isn't a very useful test.
Thanks for finding this, quite shame bug. I've fixed this in my
l2-mtd-2.6.git tree:
http://git.infradead.org/users/dedekind/l2-mtd-2.6.git/commit/e109a419146efa5751642a11caf32b96fe187130
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
prev parent reply other threads:[~2009-11-27 15:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-11 21:57 Fix argument order in incorrect memset invocations in hyperv driver Dave Jones
2009-11-26 11:07 ` Memset of length zero bugs Török Edwin
2009-11-26 16:45 ` Török Edwin
2009-11-27 15:04 ` Artem Bityutskiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1259334242.7518.31.camel@localhost \
--to=artem.bityutskiy@nokia.com \
--cc=davej@redhat.com \
--cc=dwmw2@infradead.org \
--cc=edwintorok@gmail.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.