From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1NE8NA-0005oA-06 for mharc-grub-devel@gnu.org; Fri, 27 Nov 2009 16:29:00 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NE8N8-0005mg-7p for grub-devel@gnu.org; Fri, 27 Nov 2009 16:28:58 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NE8N3-0005lX-Ck for grub-devel@gnu.org; Fri, 27 Nov 2009 16:28:57 -0500 Received: from [199.232.76.173] (port=59890 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NE8N3-0005lT-A6 for grub-devel@gnu.org; Fri, 27 Nov 2009 16:28:53 -0500 Received: from moutng.kundenserver.de ([212.227.126.186]:60702) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NE8N2-0002M8-Sa for grub-devel@gnu.org; Fri, 27 Nov 2009 16:28:53 -0500 Received: from [85.180.28.98] (e180028098.adsl.alicedsl.de [85.180.28.98]) by mrelayeu.kundenserver.de (node=mreu1) with ESMTP (Nemesis) id 0Lsuti-1OGarp11KM-012iBY; Fri, 27 Nov 2009 22:28:51 +0100 From: Felix Zielcke To: The development of GNU GRUB In-Reply-To: <4B104397.4060806@gmail.com> References: <1259181468.2806.15.camel@fz.local> <4B104397.4060806@gmail.com> Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-h/cO+63k3DEhmWjRf1AN" Date: Fri, 27 Nov 2009 22:28:50 +0100 Message-ID: <1259357330.2789.6.camel@fz.local> Mime-Version: 1.0 X-Mailer: Evolution 2.29.2 X-Provags-ID: V01U2FsdGVkX19jPJgt+pEEb7N65Kv+mGmFyGVCF4PKs3KS+QX tiWllN+T2G63en17ovNdTBtisog82yadmqJqsjFWQErQvbL9gk O+trcUptPJo4rRE5dIo2w== X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: grub_halt() X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Nov 2009 21:28:58 -0000 --=-h/cO+63k3DEhmWjRf1AN Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Am Freitag, den 27.11.2009, 22:24 +0100 schrieb Vladimir '=CF=86-coder/phcoder' Serbinenko: > Felix Zielcke wrote: > > grub_halt is on i386-pc defined as `void grub_halt (int no_apm)' but > > everywhere else as `grub_halt (void)' > > util/grub-emu.c has a #ifdef for these 2 > > > > Shouldn't we just add an int parameter everywhere to make this more > > simple? > > > > =20 > I think in future we'll have more different halt methods on different > platforms. So we could do: > grub_halt (int methods) > And have e.g. > GRUB_HALT_DEFAULT_METHODS > And e.g. on i386: > #define GRUB_HALT_DEFAULT_METHODS > (GRUB_HALT_APM|GRUB_HALT_ACPI|GRUB_HALT_HANG) Wouldn't be an enum then be better? But I don't know how to handle this with asm where currently grub_halt() on i386 seems to be actually defined. > > grub-emu fails to build on powerpc now because grub/cpu/halt.h > doestn't > > exist there: > > > https://buildd.debian.org/fetch.cgi?pkg=3Dgrub2;ver=3D1.97%2B20091125-1;a= r > ch=3Dpowerpc;stamp=3D1259179180 > > =20 It fails also on sparc because of this. --=20 Felix Zielcke Proud Debian Maintainer and GNU GRUB developer --=-h/cO+63k3DEhmWjRf1AN Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Dies ist ein digital signierter Nachrichtenteil -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iQEcBAABAgAGBQJLEESSAAoJEH84BcfYL7nIJCwH/05XWTJH/7k0Vlb1xi66Rf2e bw1cTap/kKFUgG/Ll9BAs5H3xrNB5hPJ9zo2i37+n+spBL7wthRDLX8Gv2Kx9+Ee oH1x+1Zi4Qlsk9QnJrUGTjrX1P5qw4xNFKOfhMbb1LXb22NLOzz8BYocOzJ4XsEC 14FWCu8xjYwl2XX86HU3DyJgMxnu0HLVq+qTvC71CVgerUxGoBB0MF8p5DjKLnlC Z27hrLI67DgpA/Qo5N4M8rR9u0/P+XOUssPYcu0h8DzHu3ewtT+EcASJq7301qE9 wPOSGG/kyzarGDRBn+/TltvyC7x+LeY01xHwojA129GCy1j+WW+oM8ThqhGhr4A= =KpwB -----END PGP SIGNATURE----- --=-h/cO+63k3DEhmWjRf1AN--