From: Ben Hutchings <ben@decadent.org.uk>
To: Jeff Garzik <jeff@garzik.org>
Cc: "Aníbal Monsalve Salazar" <anibal@debian.org>,
netdev <netdev@vger.kernel.org>
Subject: [PATCH] ethtool: Remove duplicate type definitions
Date: Sun, 29 Nov 2009 15:40:42 +0000 [thread overview]
Message-ID: <1259509242.3709.69.camel@localhost> (raw)
<linux/ethtool.h> and ethtool-copy.h now include <linux/types.h>, which
provides these type definitions.
The duplicate type definitions in ethtool-util.h conflict with those in
<asm/types.h> on Alpha, as reported in <http://bugs.debian.org/545850>.
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
--- a/ethtool-util.h
+++ b/ethtool-util.h
@@ -5,11 +5,7 @@
#include <sys/types.h>
-/* hack, so we may include kernel's ethtool.h */
-typedef unsigned long long __u64;
-typedef __uint32_t __u32; /* ditto */
-typedef __uint16_t __u16; /* ditto */
-typedef __uint8_t __u8; /* ditto */
+#include "ethtool-copy.h"
/* historical: we used to use kernel-like types; remove these once cleaned */
typedef unsigned long long u64;
@@ -17,8 +13,6 @@
typedef __uint16_t u16; /* ditto */
typedef __uint8_t u8; /* ditto */
-#include "ethtool-copy.h"
-
/* National Semiconductor DP83815, DP83816 */
int natsemi_dump_regs(struct ethtool_drvinfo *info, struct ethtool_regs *regs);
int natsemi_dump_eeprom(struct ethtool_drvinfo *info,
--
Ben Hutchings
Quantity is no substitute for quality, but it's the only one we've got.
next reply other threads:[~2009-11-29 15:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-29 15:40 Ben Hutchings [this message]
2009-11-30 13:30 ` [PATCH] ethtool: Remove duplicate type definitions Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1259509242.3709.69.camel@localhost \
--to=ben@decadent.org.uk \
--cc=anibal@debian.org \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.