All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: linux-ide@vger.kernel.org
Subject: libata hotplug question
Date: Mon, 30 Nov 2009 17:04:12 +1100	[thread overview]
Message-ID: <1259561052.2076.73.camel@pasglop> (raw)

So pata_macio is starting to look good, it even suspends and resumes on
a couple of test laptops, now is time to sort out the last piece of the
puzzle, which is the hotplug media-bay.

The old code use to call directly into drivers/ide ide_port_scan()
etc... from within the mediabay driver. Pretty filthy.

I'm changing that to something that's even simpler: the macio_driver
gets a new callback for plug/unplug events from the bay, so it will be
easy to keep the old driver do whatever drivers/ide cruft it wants
locally and do something different in libata.

Now, for libata, I haven't totally figured out what to do though.

It seems like when the state "changes", I can do something like ahci and
call ata_ehi_hotplugged() followed by something like ata_port_freeze()
to kick the EH... at least that's my rough understanding.

But I don't quite get how to inform libata that the part has or has not
something plugged in it. I thought about playing with the probe_mask but
it looks like ata_eh_link_autopsy() will reset that since I'm PATA, not
SATA and thus have no sata_scr_read()...

Any suggestion here ?

Cheers,
Ben.




             reply	other threads:[~2009-11-30  6:04 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-30  6:04 Benjamin Herrenschmidt [this message]
2009-11-30 23:44 ` libata hotplug question Benjamin Herrenschmidt
2009-11-30 23:48   ` Tejun Heo
2009-12-01  0:05     ` Benjamin Herrenschmidt
2009-12-01  2:43     ` Benjamin Herrenschmidt
2009-12-01  4:51       ` Tejun Heo
2009-12-01  5:24         ` Benjamin Herrenschmidt
2009-12-01  5:17       ` Benjamin Herrenschmidt
2009-12-01  5:22         ` Tejun Heo
2009-12-01  5:30           ` Benjamin Herrenschmidt
2009-12-01  5:34             ` Tejun Heo
2009-12-01  5:39               ` Benjamin Herrenschmidt
2009-12-01  5:57                 ` Benjamin Herrenschmidt
2009-12-01  5:35           ` Benjamin Herrenschmidt
2009-11-30 23:46 ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1259561052.2076.73.camel@pasglop \
    --to=benh@kernel.crashing.org \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.