From: Michael Ellerman <michael@ellerman.id.au>
To: Albert Herranz <albert_herranz@yahoo.es>
Cc: Richard Holden <aciddeath@gmail.com>, linuxppc-dev@lists.ozlabs.org
Subject: Re: [RFC PATCH v3 3/3] powerpc: gamecube/wii: early debugging using usbgecko
Date: Tue, 01 Dec 2009 16:40:11 +1100 [thread overview]
Message-ID: <1259646011.4502.4.camel@concordia> (raw)
In-Reply-To: <4B14A834.4070907@yahoo.es>
[-- Attachment #1: Type: text/plain, Size: 1020 bytes --]
On Tue, 2009-12-01 at 06:23 +0100, Albert Herranz wrote:
> Richard Holden wrote:
> >> diff --git a/arch/powerpc/platforms/embedded6xx/usbgecko_udbg.c b/arch/powerpc/platforms/embedded6xx/usbgecko_udbg.c
> >> index ba4c7cc..3f125b6 100644
> >> --- a/arch/powerpc/platforms/embedded6xx/usbgecko_udbg.c
> >> +++ b/arch/powerpc/platforms/embedded6xx/usbgecko_udbg.c
> >> @@ -17,6 +17,7 @@
> >> #include <asm/io.h>
> >> #include <asm/prom.h>
> >> #include <asm/udbg.h>
> >> +#include <asm/fixmap.h>
> >>
> >> #include "usbgecko_udbg.h"
> >>
> >> @@ -270,3 +271,61 @@ done:
> >> of_node_put(np);
> >> return;
> >> }
> >> +
> >> +#ifdef CONFIG_PPC_EARLY_DEBUG_USBGECKO
> >> +
> >> +static void __init ug_early_remap(void)
> >
> > you may want to rename the ug_ prefix, it took me a while looking back
> > and forth through the patch to convince myself it wasn't a typo.
> >
>
> What's wrong with ug_ ? (ug = (u)sb(g)ecko)
What's wrong with usb_gecko_early_remap() :)
cheers
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2009-12-01 5:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-30 23:09 [RFC PATCH v3 0/3] rework of usbgecko-based early debug Albert Herranz
2009-11-30 23:09 ` [RFC PATCH v3 1/3] powerpc: udbg: add early remap hook Albert Herranz
2009-11-30 23:09 ` [RFC PATCH v3 2/3] powerpc: udbg: add fixmap entry for early debug Albert Herranz
2009-12-01 10:51 ` Benjamin Herrenschmidt
2009-11-30 23:09 ` [RFC PATCH v3 3/3] powerpc: gamecube/wii: early debugging using usbgecko Albert Herranz
2009-12-01 1:25 ` Richard Holden
2009-12-01 5:23 ` Albert Herranz
2009-12-01 5:40 ` Michael Ellerman [this message]
2009-12-01 5:45 ` Albert Herranz
2009-12-01 7:43 ` Richard Holden
2009-12-03 4:06 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1259646011.4502.4.camel@concordia \
--to=michael@ellerman.id.au \
--cc=aciddeath@gmail.com \
--cc=albert_herranz@yahoo.es \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.