From: Peter Zijlstra <peterz@infradead.org>
To: Tejun Heo <tj@kernel.org>
Cc: Mike Galbraith <efault@gmx.de>,
tglx@linutronix.de, mingo@elte.hu, avi@redhat.com,
rusty@rustcorp.com.au, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/7] sched: refactor try_to_wake_up()
Date: Wed, 02 Dec 2009 12:01:19 +0100 [thread overview]
Message-ID: <1259751679.4003.466.camel@laptop> (raw)
In-Reply-To: <4B163DEA.2050303@kernel.org>
On Wed, 2009-12-02 at 19:14 +0900, Tejun Heo wrote:
> On 12/02/2009 07:10 PM, Mike Galbraith wrote:
> >>> I think it would _look_ better with the thing just
> >>> duplicated/stripped down and called what it is,
> >>> sched_notifier_wakeup() or such.
> >>
> >> Sorry, I'm not following. Can you elaborate a bit?
> >
> > I mean copying ttwu, stripping out locking etc, and renaming the result
> > would look better. No functional difference though, and binary growth
> > would be left in the wake of such a duplication.
>
> Ah... okay. Well, that was the first approach (with some missing
> parts). Peter wasn't particularly happy with code duplication and
> suggested refactoring ttwu and reuse common parts.
Right, esp since it missed some parts.
I haven't yet had time to look at this patch, but yeah, sharing code
seems like a good idea since its tricky and fragile code.
next prev parent reply other threads:[~2009-12-02 11:02 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-02 3:56 [PATCHSET tip/sched/core] sched: concurrency managed workqueue related sched patches Tejun Heo
2009-12-02 3:56 ` [PATCH 1/7] sched: revert 498657a478c60be092208422fefa9c7b248729c2 Tejun Heo
2009-12-02 10:42 ` [tip:sched/core] sched: Revert 498657a478c60be092208422fefa9c7b248729c2 tip-bot for Tejun Heo
2009-12-02 3:56 ` [PATCH 2/7] sched: rename preempt_notifiers to sched_notifiers and refactor implementation Tejun Heo
2009-12-02 3:56 ` [PATCH 3/7] sched: refactor try_to_wake_up() Tejun Heo
2009-12-02 9:05 ` Mike Galbraith
2009-12-02 9:51 ` Tejun Heo
2009-12-02 10:10 ` Mike Galbraith
2009-12-02 10:14 ` Tejun Heo
2009-12-02 11:01 ` Peter Zijlstra [this message]
2009-12-03 6:11 ` [PATCH UDPATED " Tejun Heo
2009-12-02 3:56 ` [PATCH 4/7] sched: implement force_cpus_allowed() Tejun Heo
2009-12-04 10:40 ` Peter Zijlstra
2009-12-04 10:43 ` Peter Zijlstra
2009-12-07 4:34 ` Tejun Heo
2009-12-07 8:35 ` Peter Zijlstra
2009-12-07 10:34 ` Tejun Heo
2009-12-07 10:54 ` Peter Zijlstra
2009-12-07 11:07 ` Tejun Heo
2009-12-08 8:41 ` Tejun Heo
2009-12-08 9:02 ` Peter Zijlstra
2009-12-08 9:12 ` Tejun Heo
2009-12-08 10:34 ` Peter Zijlstra
2009-12-08 10:38 ` Peter Zijlstra
2009-12-08 11:26 ` Tejun Heo
2009-12-08 11:24 ` Tejun Heo
2009-12-08 11:48 ` Peter Zijlstra
2009-12-08 11:56 ` Tejun Heo
2009-12-08 12:10 ` Peter Zijlstra
2009-12-08 12:23 ` Tejun Heo
2009-12-08 13:35 ` Peter Zijlstra
2009-12-09 5:25 ` Tejun Heo
2009-12-09 7:41 ` Peter Zijlstra
2009-12-09 8:03 ` Tejun Heo
2009-12-02 3:56 ` [PATCH 5/7] sched: make sched_notifiers unconditional Tejun Heo
2009-12-02 3:56 ` [PATCH 6/7] sched: add wakeup/sleep sched_notifiers and allow NULL notifier ops Tejun Heo
2009-12-02 3:56 ` [PATCH 7/7] sched: implement try_to_wake_up_local() Tejun Heo
2009-12-03 6:13 ` [PATCH UPDATED " Tejun Heo
2009-12-04 10:47 ` Peter Zijlstra
2009-12-07 3:31 ` Tejun Heo
2009-12-04 10:44 ` [PATCH " Peter Zijlstra
2009-12-07 3:26 ` Tejun Heo
2009-12-07 8:50 ` Peter Zijlstra
2009-12-07 8:56 ` Peter Zijlstra
2009-12-07 10:27 ` Tejun Heo
2009-12-08 8:53 ` Peter Zijlstra
2009-12-08 9:16 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1259751679.4003.466.camel@laptop \
--to=peterz@infradead.org \
--cc=avi@redhat.com \
--cc=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rusty@rustcorp.com.au \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.