All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Pravin Bathija <pbathija@amcc.com>
Cc: linuxppc-dev@ozlabs.org, Eric.Moore@lsi.com, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] [SCSI] mpt fusion: Fix 32 bit platforms with 64 bit resources.
Date: Thu, 03 Dec 2009 13:59:50 +1100	[thread overview]
Message-ID: <1259809190.2076.1194.camel@pasglop> (raw)
In-Reply-To: <1259805106-23636-1-git-send-email-pbathija@amcc.com>

On Wed, 2009-12-02 at 17:51 -0800, Pravin Bathija wrote:
> Powerpc 44x uses 36 bit real address while the real address defined
>     in MPT Fusion driver is of type 32 bit. This causes ioremap to fail and driver
>     fails to initialize. This fix changes the data types representing the real
>     address from unsigned long 32-bit types to resource_size_t which is 64-bit. The
>     driver has been tested, the disks get discovered correctly and can do IO.
> 
> Signed-off-by: Pravin Bathija <pbathija@amcc.com>

Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
---

James, this one should be good ;-)

> Acked-by: Feng Kan <fkan@amcc.com>
> Acked-by: Fushen Chen <fchen@amcc.com>
> Acked-by: Loc Ho <lho@amcc.com>
> Acked-by: Tirumala Reddy Marri <tmarri@amcc.com>
> Acked-by: Victor Gallardo <vgallardo@amcc.com>
> ---
>  drivers/message/fusion/mptbase.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/message/fusion/mptbase.c b/drivers/message/fusion/mptbase.c
> index 5d496a9..9f14a60 100644
> --- a/drivers/message/fusion/mptbase.c
> +++ b/drivers/message/fusion/mptbase.c
> @@ -1511,7 +1511,7 @@ mpt_mapresources(MPT_ADAPTER *ioc)
>  {
>  	u8		__iomem *mem;
>  	int		 ii;
> -	unsigned long	 mem_phys;
> +	resource_size_t	 mem_phys;
>  	unsigned long	 port;
>  	u32		 msize;
>  	u32		 psize;

  reply	other threads:[~2009-12-03  2:59 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-03  1:51 [PATCH] [SCSI] mpt fusion: Fix 32 bit platforms with 64 bit resources Pravin Bathija
2009-12-03  1:51 ` Pravin Bathija
2009-12-03  2:59 ` Benjamin Herrenschmidt [this message]
2009-12-03  5:26   ` Desai, Kashyap
2009-12-03  5:26     ` Desai, Kashyap
2009-12-03  8:56 ` Wolfgang Denk
2009-12-03  8:56   ` Wolfgang Denk
2009-12-03 23:21   ` Pravin Bathija
2009-12-03 23:21     ` Pravin Bathija
2009-12-03 23:48     ` Benjamin Herrenschmidt
2009-12-03 23:48       ` Benjamin Herrenschmidt
2009-12-10 15:43 ` James Bottomley
2009-12-10 15:43   ` James Bottomley
2009-12-10 16:36   ` Anatolij Gustschin
2009-12-10 16:36     ` Anatolij Gustschin
  -- strict thread matches above, loose matches on Subject: below --
2009-11-18  0:16 pbathija
2009-11-18  0:16 ` pbathija
2009-11-18  5:41 ` Benjamin Herrenschmidt
2009-11-18  5:41   ` Benjamin Herrenschmidt
2009-09-15 22:25 pbathija
2009-11-05 13:43 ` Josh Boyer
2009-11-05 13:43   ` Josh Boyer
2009-11-05 16:07   ` James Bottomley
2009-11-05 16:07     ` James Bottomley
2009-11-05 16:25     ` Josh Boyer
2009-11-05 16:25       ` Josh Boyer
2009-11-05 20:00     ` Benjamin Herrenschmidt
2009-11-06  4:59       ` Desai, Kashyap
2009-11-06  4:59         ` Desai, Kashyap
2009-11-06  5:49       ` Pravin Bathija
2009-11-06  5:49         ` Pravin Bathija
2009-11-06  5:57       ` Pravin Bathija
2009-11-06  5:57         ` Pravin Bathija
2009-09-09  0:15 pbathija
2009-09-15 10:29 ` Benjamin Herrenschmidt
2009-09-15 10:29   ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1259809190.2076.1194.camel@pasglop \
    --to=benh@kernel.crashing.org \
    --cc=Eric.Moore@lsi.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=pbathija@amcc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.