From: Andrew Patterson <andrew.patterson@hp.com>
To: Stefan Assmann <sassmann@redhat.com>
Cc: linux-pci@vger.kernel.org, jeff@garzik.org,
linux-kernel@vger.kernel.org, jbarnes@virtuousgeek.org,
rjw@sisk.pl, ddutile@redhat.com, kaneshige.kenji@jp.fujitsu.com,
khc@pm.waw.pl
Subject: Re: [PATCH 2/2 v2] pci: change PCI nomenclature in drivers/pci/ (non-comment changes)
Date: Thu, 03 Dec 2009 09:27:22 -0700 [thread overview]
Message-ID: <1259857642.2684.64.camel@grinch> (raw)
In-Reply-To: <20091203114932.24905.78292.sendpatchset@localhost.localdomain>
On Thu, 2009-12-03 at 06:49 -0500, Stefan Assmann wrote:
> From: Stefan Assmann <sassmann@redhat.com>
>
> Changing occurrences of variants of PCI-X and PCIe to the PCI-SIG
> terms listed in the "Trademark and Logo Usage Guidelines".
> http://www.pcisig.com/developers/procedures/logos/Trademark_and_Logo_Usage_Guidelines_updated_112206.pdf
>
> Patch is limited to drivers/pci/ and changes concern non-comment parts or
> anything that might be visible to the user.
>
> Signed-off-by: Stefan Assmann <sassmann@redhat.com>
> ---
> drivers/pci/hotplug/pci_hotplug_core.c | 22 +++++++++++-----------
> drivers/pci/pcie/aer/Kconfig.debug | 4 ++--
> drivers/pci/pcie/aer/aer_inject.c | 2 +-
> drivers/pci/pcie/aer/aerdrv_errprint.c | 4 ++--
> drivers/pci/pcie/portdrv_pci.c | 2 +-
> 5 files changed, 17 insertions(+), 17 deletions(-)
>
> diff --git a/drivers/pci/hotplug/pci_hotplug_core.c b/drivers/pci/hotplug/pci_hotplug_core.c
> index 0325d98..38183a5 100644
> --- a/drivers/pci/hotplug/pci_hotplug_core.c
> +++ b/drivers/pci/hotplug/pci_hotplug_core.c
> @@ -68,26 +68,26 @@ static DEFINE_MUTEX(pci_hp_mutex);
> static char *pci_bus_speed_strings[] = {
> "33 MHz PCI", /* 0x00 */
> "66 MHz PCI", /* 0x01 */
> - "66 MHz PCIX", /* 0x02 */
> - "100 MHz PCIX", /* 0x03 */
> - "133 MHz PCIX", /* 0x04 */
> + "66 MHz PCI-X", /* 0x02 */
> + "100 MHz PCI-X", /* 0x03 */
> + "133 MHz PCI-X", /* 0x04 */
> NULL, /* 0x05 */
> NULL, /* 0x06 */
> NULL, /* 0x07 */
> NULL, /* 0x08 */
> - "66 MHz PCIX 266", /* 0x09 */
> - "100 MHz PCIX 266", /* 0x0a */
> - "133 MHz PCIX 266", /* 0x0b */
> + "66 MHz PCI-X 266", /* 0x09 */
> + "100 MHz PCI-X 266", /* 0x0a */
> + "133 MHz PCI-X 266", /* 0x0b */
> NULL, /* 0x0c */
> NULL, /* 0x0d */
> NULL, /* 0x0e */
> NULL, /* 0x0f */
> NULL, /* 0x10 */
> - "66 MHz PCIX 533", /* 0x11 */
> - "100 MHz PCIX 533", /* 0x12 */
> - "133 MHz PCIX 533", /* 0x13 */
> - "2.5 GT/s PCI-E", /* 0x14 */
> - "5.0 GT/s PCI-E", /* 0x15 */
> + "66 MHz PCI-X 533", /* 0x11 */
> + "100 MHz PCI-X 533", /* 0x12 */
> + "133 MHz PCI-X 533", /* 0x13 */
> + "2.5 GT/s PCIe", /* 0x14 */
> + "5.0 GT/s PCIe", /* 0x15 */
> };
>
> #ifdef CONFIG_HOTPLUG_PCI_CPCI
> diff --git a/drivers/pci/pcie/aer/Kconfig.debug b/drivers/pci/pcie/aer/Kconfig.debug
> index b8c925c..edfe756 100644
> --- a/drivers/pci/pcie/aer/Kconfig.debug
> +++ b/drivers/pci/pcie/aer/Kconfig.debug
> @@ -3,14 +3,14 @@
> #
>
> config PCIEAER_INJECT
> - tristate "PCIE AER error injector support"
> + tristate "PCIe AER error injector support"
> depends on PCIEAER
> default n
> help
> This enables PCI Express Root Port Advanced Error Reporting
> (AER) software error injector.
>
> - Debuging PCIE AER code is quite difficult because it is hard
> + Debuging PCIe AER code is quite difficult because it is hard
Why not fix the typo while changing this line. "Debuging" shoud be
"Debugging".
> to trigger various real hardware errors. Software based
> error injection can fake almost all kinds of errors with the
> help of a user space helper tool aer-inject, which can be
> diff --git a/drivers/pci/pcie/aer/aer_inject.c b/drivers/pci/pcie/aer/aer_inject.c
> index a21dee3..8e056f2 100644
> --- a/drivers/pci/pcie/aer/aer_inject.c
> +++ b/drivers/pci/pcie/aer/aer_inject.c
> @@ -462,5 +462,5 @@ static void __exit aer_inject_exit(void)
> module_init(aer_inject_init);
> module_exit(aer_inject_exit);
>
> -MODULE_DESCRIPTION("PCIE AER software error injector");
> +MODULE_DESCRIPTION("PCIe AER software error injector");
> MODULE_LICENSE("GPL");
> diff --git a/drivers/pci/pcie/aer/aerdrv_errprint.c b/drivers/pci/pcie/aer/aerdrv_errprint.c
> index 44acde7..9d3e4c8 100644
> --- a/drivers/pci/pcie/aer/aerdrv_errprint.c
> +++ b/drivers/pci/pcie/aer/aerdrv_errprint.c
> @@ -184,7 +184,7 @@ void aer_print_error(struct pci_dev *dev, struct aer_err_info *info)
>
> if (info->status == 0) {
> AER_PR(info, dev,
> - "PCIE Bus Error: severity=%s, type=Unaccessible, "
> + "PCIe Bus Error: severity=%s, type=Unaccessible, "
> "id=%04x(Unregistered Agent ID)\n",
> aer_error_severity_string[info->severity], id);
> } else {
> @@ -194,7 +194,7 @@ void aer_print_error(struct pci_dev *dev, struct aer_err_info *info)
> agent = AER_GET_AGENT(info->severity, info->status);
>
> AER_PR(info, dev,
> - "PCIE Bus Error: severity=%s, type=%s, id=%04x(%s)\n",
> + "PCIe Bus Error: severity=%s, type=%s, id=%04x(%s)\n",
> aer_error_severity_string[info->severity],
> aer_error_layer[layer], id, aer_agent_string[agent]);
>
> diff --git a/drivers/pci/pcie/portdrv_pci.c b/drivers/pci/pcie/portdrv_pci.c
> index f635e47..6788d0f 100644
> --- a/drivers/pci/pcie/portdrv_pci.c
> +++ b/drivers/pci/pcie/portdrv_pci.c
> @@ -24,7 +24,7 @@
> */
> #define DRIVER_VERSION "v1.0"
> #define DRIVER_AUTHOR "tom.l.nguyen@intel.com"
> -#define DRIVER_DESC "PCIE Port Bus Driver"
> +#define DRIVER_DESC "PCIe Port Bus Driver"
> MODULE_AUTHOR(DRIVER_AUTHOR);
> MODULE_DESCRIPTION(DRIVER_DESC);
> MODULE_LICENSE("GPL");
--
Andrew Patterson
Hewlett-Packard
next prev parent reply other threads:[~2009-12-03 16:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-03 11:49 [PATCH 0/2 v2] pci: change PCI nomenclature according to PCI-SIG Stefan Assmann
2009-12-03 11:49 ` [PATCH 1/2 v2] pci: change PCI nomenclature in drivers/pci/ (comment changes) Stefan Assmann
2009-12-03 17:04 ` Stefan Assmann
2009-12-03 17:43 ` Jeff Garzik
2009-12-16 19:45 ` Jesse Barnes
2009-12-03 11:49 ` [PATCH 2/2 v2] pci: change PCI nomenclature in drivers/pci/ (non-comment changes) Stefan Assmann
2009-12-03 16:27 ` Andrew Patterson [this message]
2009-12-03 17:00 ` Stefan Assmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1259857642.2684.64.camel@grinch \
--to=andrew.patterson@hp.com \
--cc=ddutile@redhat.com \
--cc=jbarnes@virtuousgeek.org \
--cc=jeff@garzik.org \
--cc=kaneshige.kenji@jp.fujitsu.com \
--cc=khc@pm.waw.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.