From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH] xen: allow CONFIG_ACPI_PROCESSOR_XEN=m Date: Thu, 3 Dec 2009 22:46:02 +0000 Message-ID: <1259880362.31045.154.camel@localhost.localdomain> References: <1259877811-32572-1-git-send-email-ian.campbell@citrix.com> <4B183E8F.6040601@goop.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <4B183E8F.6040601@goop.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jeremy Fitzhardinge Cc: "xen-devel@lists.xensource.com" , Jeremy, Fitzhardinge , Yu Ke List-Id: xen-devel@lists.xenproject.org On Thu, 2009-12-03 at 22:41 +0000, Jeremy Fitzhardinge wrote:=20 > On 12/03/09 14:03, Ian Campbell wrote: > > diff --git a/include/xen/acpi.h b/include/xen/acpi.h > > index 3d7ea40..8506688 100644 > > --- a/include/xen/acpi.h > > +++ b/include/xen/acpi.h > > @@ -41,7 +41,7 @@ int acpi_notify_hypervisor_state(u8 sleep_state, > > #define HOTPLUG_TYPE_ADD 0 > > #define HOTPLUG_TYPE_REMOVE 1 > > > > -#ifdef CONFIG_ACPI_PROCESSOR_XEN > > +#if defined(CONFIG_ACPI_PROCESSOR_XEN) || defined(CONFIG_ACPI_PROCES= SOR_XEN_MODULE) > > =20 >=20 > Is this necessary? I thought =3Dm defined CONFIG_ACPI_PROCESSOR_XE. I thought so too but I got a build error without this change: CC [M] drivers/xen/acpi_processor.o drivers/xen/acpi_processor.c:41: error: variable =E2=80=98xen_ops=E2=80=99= has initializer but incomplete type drivers/xen/acpi_processor.c:42: error: unknown field =E2=80=98hotplug=E2= =80=99 specified in initializer drivers/xen/acpi_processor.c:42: warning: excess elements in struct initi= alizer drivers/xen/acpi_processor.c:42: warning: (near initialization for =E2=80= =98xen_ops=E2=80=99) drivers/xen/acpi_processor.c:47: error: redefinition of =E2=80=98processo= r_cntl_xen_power_cache=E2=80=99 include/xen/acpi.h:74: error: previous definition of =E2=80=98processor_c= ntl_xen_power_cache=E2=80=99 was here drivers/xen/acpi_processor.c:72: error: redefinition of =E2=80=98processo= r_cntl_xen=E2=80=99 include/xen/acpi.h:63: error: previous definition of =E2=80=98processor_c= ntl_xen=E2=80=99 was here drivers/xen/acpi_processor.c:78: error: redefinition of =E2=80=98processo= r_cntl_xen_pm=E2=80=99 include/xen/acpi.h:64: error: previous definition of =E2=80=98processor_c= ntl_xen_pm=E2=80=99 was here drivers/xen/acpi_processor.c: In function =E2=80=98processor_cntl_xen_pm=E2= =80=99: drivers/xen/acpi_processor.c:80: error: invalid use of undefined type =E2= =80=98struct processor_cntl_xen_ops=E2=80=99 drivers/xen/acpi_processor.c: At top level: drivers/xen/acpi_processor.c:84: error: redefinition of =E2=80=98processo= r_cntl_xen_pmperf=E2=80=99 include/xen/acpi.h:65: error: previous definition of =E2=80=98processor_c= ntl_xen_pmperf=E2=80=99 was here drivers/xen/acpi_processor.c: In function =E2=80=98processor_cntl_xen_pmp= erf=E2=80=99: drivers/xen/acpi_processor.c:86: error: invalid use of undefined type =E2= =80=98struct processor_cntl_xen_ops=E2=80=99 drivers/xen/acpi_processor.c: At top level: drivers/xen/acpi_processor.c:90: error: redefinition of =E2=80=98processo= r_cntl_xen_pmthr=E2=80=99 include/xen/acpi.h:66: error: previous definition of =E2=80=98processor_c= ntl_xen_pmthr=E2=80=99 was here drivers/xen/acpi_processor.c: In function =E2=80=98processor_cntl_xen_pmt= hr=E2=80=99: drivers/xen/acpi_processor.c:92: error: invalid use of undefined type =E2= =80=98struct processor_cntl_xen_ops=E2=80=99 drivers/xen/acpi_processor.c: At top level: drivers/xen/acpi_processor.c:96: error: redefinition of =E2=80=98processo= r_cntl_xen_notify=E2=80=99 include/xen/acpi.h:69: error: previous definition of =E2=80=98processor_c= ntl_xen_notify=E2=80=99 was here drivers/xen/acpi_processor.c: In function =E2=80=98processor_cntl_xen_not= ify=E2=80=99: drivers/xen/acpi_processor.c:104: error: invalid use of undefined type =E2= =80=98struct processor_cntl_xen_ops=E2=80=99 drivers/xen/acpi_processor.c:107: error: invalid use of undefined type =E2= =80=98struct processor_cntl_xen_ops=E2=80=99 drivers/xen/acpi_processor.c:110: error: invalid use of undefined type =E2= =80=98struct processor_cntl_xen_ops=E2=80=99 drivers/xen/acpi_processor.c:111: error: invalid use of undefined type =E2= =80=98struct processor_cntl_xen_ops=E2=80=99 drivers/xen/acpi_processor.c: In function =E2=80=98xen_acpi_processor_ext= cntl_init=E2=80=99: drivers/xen/acpi_processor.c:327: error: invalid use of undefined type =E2= =80=98struct processor_cntl_xen_ops=E2=80=99 drivers/xen/acpi_processor.c:329: error: invalid use of undefined type =E2= =80=98struct processor_cntl_xen_ops=E2=80=99 drivers/xen/acpi_processor.c:331: error: invalid use of undefined type =E2= =80=98struct processor_cntl_xen_ops=E2=80=99 make[2]: *** [drivers/xen/acpi_processor.o] Error 1 make[1]: *** [drivers/xen/] Error 2 make: *** [sub-make] Error 2 Ian.