From: Mingming <cmm@us.ibm.com>
To: Dmitry Monakhov <dmonakhov@openvz.org>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH 1/4] ext4: ext4_get_reserved_space() must return bytes instead of blocks
Date: Mon, 07 Dec 2009 17:04:41 -0800 [thread overview]
Message-ID: <1260234281.4206.152.camel@mingming-laptop> (raw)
In-Reply-To: <1259132261-16785-1-git-send-email-dmonakhov@openvz.org>
On Wed, 2009-11-25 at 09:57 +0300, Dmitry Monakhov wrote:
> Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org>
> ---
> fs/ext4/inode.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
> index ab22297..cc4737e 100644
> --- a/fs/ext4/inode.c
> +++ b/fs/ext4/inode.c
> @@ -1057,7 +1057,7 @@ qsize_t ext4_get_reserved_space(struct inode *inode)
> EXT4_I(inode)->i_reserved_meta_blocks;
> spin_unlock(&EXT4_I(inode)->i_block_reservation_lock);
>
> - return total;
> + return (total << inode->i_blkbits);
> }
> /*
> * Calculate the number of metadata blocks need to reserve
It's a pity that we missed this fix at the time the change set merge to
the upstream, thanks for catching this.
Acked-by: Mingming Cao <cmm@us.ibm.com>
Mingming
prev parent reply other threads:[~2009-12-08 1:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-25 6:57 [PATCH 1/4] ext4: ext4_get_reserved_space() must return bytes instead of blocks Dmitry Monakhov
2009-11-25 6:57 ` [PATCH 2/4] ext4: fix reserved space transferring on chown() [V2] Dmitry Monakhov
2009-11-25 6:57 ` [PATCH 3/4] ext4: quota macros cleanup Dmitry Monakhov
2009-11-25 6:57 ` [PATCH 4/4] ext4: fix incorrect block reservation on quota transfer Dmitry Monakhov
2009-12-08 1:02 ` Mingming
2009-12-08 6:48 ` Dmitry Monakhov
2009-12-08 0:59 ` [PATCH 3/4] ext4: quota macros cleanup Mingming
2009-12-07 17:18 ` [PATCH 2/4] ext4: fix reserved space transferring on chown() [V2] Aneesh Kumar K.V
2009-12-07 19:41 ` Dmitry Monakhov
2009-12-09 1:42 ` tytso
2009-12-09 2:03 ` Dmitry Monakhov
2009-12-08 23:06 ` Mingming
2009-11-25 16:32 ` [PATCH 1/4] ext4: ext4_get_reserved_space() must return bytes instead of blocks Eric Sandeen
2009-12-08 1:04 ` Mingming [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1260234281.4206.152.camel@mingming-laptop \
--to=cmm@us.ibm.com \
--cc=dmonakhov@openvz.org \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.