From: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
To: David Miller <davem@davemloft.net>
Cc: "Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"gospo@redhat.com" <gospo@redhat.com>
Subject: Re: [net-2.6 PATCH 1/3] ixgbe: Fix compiler warning about variable being used uninitialized
Date: Sun, 13 Dec 2009 20:55:22 -0800 [thread overview]
Message-ID: <1260766522.20884.0.camel@localhost> (raw)
In-Reply-To: <20091213.192029.104053340.davem@davemloft.net>
On Sun, 2009-12-13 at 19:20 -0800, David Miller wrote:
> From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> Date: Fri, 11 Dec 2009 23:51:23 -0800
>
> > From: PJ Waskiewicz <peter.p.waskiewicz.jr@intel.com>
> >
> > tc is still throwing a warning that is could be used
> > uninitialized. This fixes it.
> >
> > Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
> > Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
>
> It's warning because it absolutely can be used uninitialized.
>
> The two code blocks only handle two chip variants. Why not
> make what's happening here explicit by using a switch
> statement and having a 'default' case?
That I can do, and makes more sense. I'll respin the patch.
Thanks Dave,
-PJ
prev parent reply other threads:[~2009-12-14 4:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-12 7:51 [net-2.6 PATCH 1/3] ixgbe: Fix compiler warning about variable being used uninitialized Jeff Kirsher
2009-12-12 7:51 ` [net-2.6 PATCH 2/3] ixgbe: Fix tx_restart_queue/non_eop_desc statistics counters Jeff Kirsher
2009-12-14 3:18 ` David Miller
2009-12-14 4:57 ` Peter P Waskiewicz Jr
2009-12-14 5:07 ` David Miller
2009-12-12 7:52 ` [net-2.6 PATCH 3/3] Fix 82598 premature copper PHY link indicatation Jeff Kirsher
2009-12-14 3:18 ` David Miller
2009-12-14 18:37 ` Malli
2009-12-14 3:20 ` [net-2.6 PATCH 1/3] ixgbe: Fix compiler warning about variable being used uninitialized David Miller
2009-12-14 4:55 ` Peter P Waskiewicz Jr [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1260766522.20884.0.camel@localhost \
--to=peter.p.waskiewicz.jr@intel.com \
--cc=davem@davemloft.net \
--cc=gospo@redhat.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.