From: Trond Myklebust <Trond.Myklebust@netapp.com>
To: Jeff Layton <jlayton@redhat.com>
Cc: linux-nfs@vger.kernel.org, nfsv4@linux-nfs.org
Subject: Re: [PATCH] sunrpc: on successful gss error pipe write, don't return error
Date: Fri, 18 Dec 2009 10:12:22 -0500 [thread overview]
Message-ID: <1261149142.3229.20.camel@localhost> (raw)
In-Reply-To: <1261147672.3229.14.camel@localhost>
On Fri, 2009-12-18 at 09:47 -0500, Trond Myklebust wrote:
> On Fri, 2009-12-18 at 09:39 -0500, Jeff Layton wrote:
> > Without a separate downcall error field, we'll need to special case at
> > least 2 different errors -- one for a "real" EACCES and one that
> > indicates that the ticket expired and the upcall should be retried
> > instead.
>
> We can find another error for the 'ticket expired' case. EKEYEXPIRED
> springs to mind...
BTW: Here be dragons!
I think we need to handle the 'ticket expired' case as if it were an
NFS4ERR_DELAY/EJUKEBOX, and actually do the retry in the NFS layer after
a suitable exponential back-off period.
Otherwise, we end up holding onto resources (in particular NFSv4.1
slots, but also RPC slots, ...) which will cause congestion, and prevent
other RPC calls from making progress.
Cheers
Trond
next prev parent reply other threads:[~2009-12-18 15:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-18 13:56 [PATCH] sunrpc: on successful gss error pipe write, don't return error Jeff Layton
2009-12-18 14:11 ` Trond Myklebust
2009-12-18 14:39 ` Jeff Layton
[not found] ` <20091218093912.1c426ad6-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
2009-12-18 14:47 ` Trond Myklebust
2009-12-18 15:12 ` Trond Myklebust [this message]
2009-12-18 15:37 ` Jeff Layton
[not found] ` <20091218103723.38510cce-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
2009-12-18 18:30 ` Trond Myklebust
2009-12-18 19:14 ` Jeff Layton
2009-12-18 19:42 ` Trond Myklebust
2009-12-18 15:25 ` Jeff Layton
2009-12-18 16:25 ` Jeff Layton
2009-12-18 19:33 ` Trond Myklebust
2009-12-18 20:14 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1261149142.3229.20.camel@localhost \
--to=trond.myklebust@netapp.com \
--cc=jlayton@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=nfsv4@linux-nfs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.