From: Ben Skeggs <skeggsb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Marcin Slusarz <marcin.slusarz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH] drm/nouveau: fix fillrect color on nv50
Date: Tue, 22 Dec 2009 08:49:13 +1000 [thread overview]
Message-ID: <1261435753.5889.0.camel@nisroch> (raw)
In-Reply-To: <20091221220041.GA2656-OI9uyE9O0yo@public.gmane.org>
On Mon, 2009-12-21 at 23:00 +0100, Marcin Slusarz wrote:
> struct fb_fillrect->color is not a color, but index into pseudo_palette array
>
Thanks, applied to git.
Ben.
> Signed-off-by: Marcin Slusarz <marcin.slusarz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
> drivers/gpu/drm/nouveau/nv50_fbcon.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nv50_fbcon.c b/drivers/gpu/drm/nouveau/nv50_fbcon.c
> index 6bcc6d3..c966ef8 100644
> --- a/drivers/gpu/drm/nouveau/nv50_fbcon.c
> +++ b/drivers/gpu/drm/nouveau/nv50_fbcon.c
> @@ -10,6 +10,7 @@ nv50_fbcon_fillrect(struct fb_info *info, const struct fb_fillrect *rect)
> struct drm_device *dev = par->dev;
> struct drm_nouveau_private *dev_priv = dev->dev_private;
> struct nouveau_channel *chan = dev_priv->channel;
> + uint32_t color = ((uint32_t *) info->pseudo_palette)[rect->color];
>
> if (info->state != FBINFO_STATE_RUNNING)
> return;
> @@ -31,7 +32,7 @@ nv50_fbcon_fillrect(struct fb_info *info, const struct fb_fillrect *rect)
> OUT_RING(chan, 1);
> }
> BEGIN_RING(chan, NvSub2D, 0x0588, 1);
> - OUT_RING(chan, rect->color);
> + OUT_RING(chan, color);
> BEGIN_RING(chan, NvSub2D, 0x0600, 4);
> OUT_RING(chan, rect->dx);
> OUT_RING(chan, rect->dy);
prev parent reply other threads:[~2009-12-21 22:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-21 22:00 [PATCH] drm/nouveau: fix fillrect color on nv50 Marcin Slusarz
[not found] ` <20091221220041.GA2656-OI9uyE9O0yo@public.gmane.org>
2009-12-21 22:49 ` Ben Skeggs [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1261435753.5889.0.camel@nisroch \
--to=skeggsb-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=marcin.slusarz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.