From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1mJjJC-0007oK-Lz for mharc-grub-devel@gnu.org; Fri, 27 Aug 2021 17:22:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33914) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mJjJA-0007ni-Ql for grub-devel@gnu.org; Fri, 27 Aug 2021 17:22:40 -0400 Received: from mout.gmx.net ([212.227.17.22]:60579) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mJjJ9-0005va-4M for grub-devel@gnu.org; Fri, 27 Aug 2021 17:22:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1630099357; bh=WYiwghKnZcUc1RN5OE6B+7Lk6/VSAYGa9fHTYUJnChs=; h=X-UI-Sender-Class:Date:From:To:Subject:Cc:References:In-Reply-To; b=GK9b+45YkubpCh6Cz3oCD+gBWBsl8vuh7N+hGdKN7ZCWwh6o2Xl3YeF8l+lZgvK03 rw3/Q+SUACyCD6u2ppqm98d7x7C1Hom+4QTzkU+X8DDaWDeu9I7KvAWHJ9ebRjHuKu q8jDtK3BL11NE6LR8Rhy7qqbQgCCohQnN51iq/uU= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from scdbackup.webframe.org ([84.179.233.243]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N6KYb-1n3kFp4601-016d3R for ; Fri, 27 Aug 2021 23:22:37 +0200 Date: Fri, 27 Aug 2021 23:23:26 +0200 From: "Thomas Schmitt" To: grub-devel@gnu.org Subject: Re: [PATCH v2 1/8] tests: Make sure LANG is set properly for iso9660_test Content-Type: text/plain; charset="utf-8" Cc: development@efficientek.com References: <20210827150347.2ed77b15@crass-HP-ZBook-15-G2> In-Reply-To: <20210827150347.2ed77b15@crass-HP-ZBook-15-G2> Message-Id: <12616361528562645898@scdbackup.webframe.org> X-Provags-ID: V03:K1:Q3KGWt+vLUpahcFyAPOudmBM3IicT7z2PykzH+ta5CxaMYhNDlT jHg1CSC5XJaBoFDuNBFbVXcCp7KdIJo6OBgaIK8PJWnDYBg1RlDE2sjMfd7s61UuJFE1bHv CJ0ykjEQUgjLOzwvJdD3YTVNf+pevpUO8KWA3RTpnZEt74P32K2mHae/mHh08GBe/KngzLv buOl7BUgsbcbphuVd4tjg== X-UI-Out-Filterresults: notjunk:1;V03:K0:XEW/HDp34pA=:VWm8Aw4kuj4lWs5ml1ae2u eFWCHqp8R/3cu8rNUg0gcopXabSPg9vVFcEIbYIRbOeAp7nkEQTonV9g0TLmCqZjMueB6RRs3 PzrhsURtzb5PPPKmM6EkCXJQGca2wyNIKqNiRysvvJMmeX7rV3pF0/8MyHOp88fPprrOlx6lo +NZA/X79JGysaIvTErMgZfOdF3nqwiB0cn3IzJuzluBgst8ebAynwA9g7zNFGOP+Iw2e/NMgl zztVZ/vuq0ijSnsD+B0Jngke46z9Sbi6olBpstKw+EZRZ5lQqan9qKkZ7hnbgPu4xRDCUD+07 sSoMNvVvP1BbA4GfsfWn9gRZprJiiFNzZYEOs767/1eFi7ze88s0IMaoc9DK9alWsGoCrLnfA 02yQQbZpf22t25VHtR4Ufv3pmFRbNjz56epG8owKVePEO5dwBwC3LeQ8dXnb0jmF0kh7tYtJA IdMZvTxvsVpejOgCwbvj9c/vKbENLNuEqUlpS4wqhYIQuRWCKhqNpq8p/Da8SR7CFgDKS6wan O8pDa0+Oa20LHEp9uKTzuMGc7L6OT/MIuOtw1WU76HStYSkDAprUAKcBNGToXUr2fORHWdViR wqc20B0RQXLx2uKFNeuOl7o04e8idr2KBagxqbhGsC7+xJuP4SX6n97fbLO0XSyu5BO5ZM6+g bCoof2EQBGKamHQ0tGV0ZPZnw7CTnh6ZZmG65APsE33LFMV2mLB4obsuvDLS+DSqEgAhZC17C NES9fB2hAactPezStsdLfa2GyX0DdhzY2CeyU0e9YhTVxL6h1OmjFchoQb/jS9m3OhMN5G4eb /PCuUW4ImHr20AmPVuVmXkqav8eL31EyO1I3BzvoEohzidWzZwuHDo2TKrPwyTEC2pDrmkbD/ yp0ClphqzEr+Sg5ZPMtVMjljcPv3oqJ5m5xHndZ7/cmXHZJxOIciJNrcU1XOOnqRgPHZDMWo0 u2ckuzjjfObMfBe22Z9xtbF3hAXsZ2pmOt5dRWMrPDDht4oJ9kknvC3OjRIPwPveGH0Y+1y0F qqTwpMMPN91c9zFwaMC6Du8XnKXPeMUhMZClG/WzrzZLyBxBIgzOeVPPIzEn5Q5gQjnh1klj3 SuP4+1wfNDVOpK6YKKcot0EoIt8Ppas61baEhBim0IY58ein9pLkBpyUg== Received-SPF: pass client-ip=212.227.17.22; envelope-from=scdbackup@gmx.net; helo=mout.gmx.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Aug 2021 21:22:41 -0000 Hi, i wrote: > > it might be contraproductive to set LANG=en_US.UTF-8. Glenn Washburn wrote: > My patch only sets LANG if empty, so in this case I don't think its > counterproductive, just not productive. Yes. It cautiously avoids to make the situation any worse. I meant my own announced plan which was more agressively aiming for enforcing UTF-8. Well, i hope that my cheat sheet for (unsuccessful) kernel contribution attempts enabled me to create a convincing imitation of an acceptable patch for GRUB. To help reading the oversized line salad: I defined the variable XORRISOFS_CHARSET and added $XORRISOFS_CHARSET after each "-as mkisofs" in the xorriso command lines. Tests were made without any LANG setting (effectively en_US.utf-8), with LANG="", "C", "en_US.ISO-8859-1" (not installed), "en_US.UTF-8", "de_DE.UTF-8" (not installed). All succeeded. Have a nice day :) Thomas