From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: Jijiang Liu <jijiang.liu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [PATCH][Dom0 driver]Change the way of reserving memory in Dom0 driver
Date: Thu, 22 May 2014 17:20:49 +0200 [thread overview]
Message-ID: <12620475.JcSW442DzY@xps13> (raw)
In-Reply-To: <1400569085-22244-1-git-send-email-jijiang.liu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Hi Jijiang,
Some cosmetic comments:
Referring to previous patch about Xen Dom0, prefix "xen:" should be used
in commit title. So it should be something like that:
xen: reserve memory at init
Maybe it could need to be splitted in 2 patches. So the other one would be:
xen: reduce number of memory segments
After running checkpatch.pl on this patch, it reports many errors.
Please, could you run it and do the required fix?
see http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/scripts/checkpatch.pl
Thanks
--
Thomas
prev parent reply other threads:[~2014-05-22 15:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-20 6:58 [PATCH][Dom0 driver]Change the way of reserving memory in Dom0 driver Jijiang Liu
[not found] ` <1400569085-22244-1-git-send-email-jijiang.liu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-05-22 15:20 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12620475.JcSW442DzY@xps13 \
--to=thomas.monjalon-pdr9zngts4eavxtiumwx3w@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
--cc=jijiang.liu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.