From: Peter Zijlstra <peterz@infradead.org>
To: Mike Galbraith <efault@gmx.de>
Cc: Arjan van de Ven <arjan@infradead.org>,
Lin Ming <ming.m.lin@intel.com>,
lkml <linux-kernel@vger.kernel.org>,
"Zhang, Yanmin" <yanmin_zhang@linux.intel.com>
Subject: Re: volano ~30% regression with 2.6.33-rc1 & -rc2
Date: Mon, 04 Jan 2010 14:02:03 +0100 [thread overview]
Message-ID: <1262610123.6408.120.camel@laptop> (raw)
In-Reply-To: <1262609854.9734.56.camel@marge.simson.net>
On Mon, 2010-01-04 at 13:57 +0100, Mike Galbraith wrote:
> On Mon, 2010-01-04 at 04:40 -0800, Arjan van de Ven wrote:
> > On Mon, 04 Jan 2010 16:15:58 +0800
> > Lin Ming <ming.m.lin@intel.com> wrote:
> >
> > > Mike & Peter,
> > >
> > > Compared with 2.6.32, volano has ~30% regression with 2.6.33-rc1 &
> > > -rc2. Testing machine: Tigerton Xeon, 16cpus(4P/4Core), 16G memory
> >
> > did this show up only on this cpu?
> > (since this is a multi-core-without-shared-cache cpu, it could be that
> > we get the topology wrong and think cores share cache where they don't)
>
> My fault for using PREFER_SIBLING I guess. However, I do wonder why in
> the heck we set that at the CPU domain level. Siblings lie northward.
Ah, PREFER_SIBLING means prefer sibling domain, not sibling thread. Its
set at the CPU (really socket) level so make tasks spread over sockets
first, so that there is no competition for the socket wide resources.
Your change is sane, but we really want a more extensive sched domain
tree in the near future, reflecting the full machine topology.
next prev parent reply other threads:[~2010-01-04 13:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-04 8:15 volano ~30% regression with 2.6.33-rc1 & -rc2 Lin Ming
2010-01-04 12:40 ` Arjan van de Ven
2010-01-04 12:57 ` Mike Galbraith
2010-01-04 13:02 ` Peter Zijlstra [this message]
2010-01-04 13:15 ` Mike Galbraith
2010-01-04 13:26 ` Peter Zijlstra
2010-01-04 13:44 ` [patch] " Mike Galbraith
2010-01-21 13:51 ` [tip:sched/urgent] sched: Fix vmark regression on big machines tip-bot for Mike Galbraith
2010-01-05 0:44 ` volano ~30% regression with 2.6.33-rc1 & -rc2 Lin Ming
2010-01-05 2:44 ` Mike Galbraith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1262610123.6408.120.camel@laptop \
--to=peterz@infradead.org \
--cc=arjan@infradead.org \
--cc=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.m.lin@intel.com \
--cc=yanmin_zhang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.