From: "Przemysław Firszt" <przemo@firszt.eu>
To: linux-bluetooth <linux-bluetooth@vger.kernel.org>,
Ping <pinglinux@gmail.com>,
Peter Hutterer <peter.hutterer@who-t.net>
Subject: [PATCH] Two small patches
Date: Mon, 04 Jan 2010 23:17:18 +0000 [thread overview]
Message-ID: <1262647038.2983.5.camel@pldmachine> (raw)
[-- Attachment #1: Type: text/plain, Size: 216 bytes --]
Hi,
2 patches:
- use defined variable is_proximity
-remove duplicate comment from xf86WacomDefs.h
Those two are not important, but I don't want to leave it till later -
"the later" it might never happen.
--
Przemo
[-- Attachment #2: 0002-is_proximity-is-defined-so-let-s-use-it.patch --]
[-- Type: text/x-patch, Size: 709 bytes --]
>From a1865a5f06f165a398d9a87d34c96b59b1d8660c Mon Sep 17 00:00:00 2001
From: Przemo Firszt <przemo@firszt.eu>
Date: Mon, 4 Jan 2010 19:25:20 +0000
Subject: [PATCH 2/3] is_proximity is defined, so let's use it
Signed-off-by: Przemo Firszt <przemo@firszt.eu>
---
src/wcmCommon.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/wcmCommon.c b/src/wcmCommon.c
index 32ad82e..1c1cc2c 100644
--- a/src/wcmCommon.c
+++ b/src/wcmCommon.c
@@ -779,7 +779,7 @@ void xf86WcmSendEvents(LocalDevicePtr local, const WacomDeviceState* ds)
}
/* don't move the cursor when going out-prox */
- if (!ds->proximity)
+ if (!is_proximity)
{
x = priv->oldX;
y = priv->oldY;
--
1.6.5.7
[-- Attachment #3: 0003-Remove-duplicate-comment-in-xf86WacomDefs.h.patch --]
[-- Type: text/x-patch, Size: 1009 bytes --]
>From 714b4b3b989ae5a36b839bd4fe229999233cd192 Mon Sep 17 00:00:00 2001
From: Przemo Firszt <przemo@firszt.eu>
Date: Mon, 4 Jan 2010 23:13:06 +0000
Subject: [PATCH 3/3] Remove duplicate comment in xf86WacomDefs.h
Signed-off-by: Przemo Firszt <przemo@firszt.eu>
---
src/xf86WacomDefs.h | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/src/xf86WacomDefs.h b/src/xf86WacomDefs.h
index 1e4a441..34a9375 100644
--- a/src/xf86WacomDefs.h
+++ b/src/xf86WacomDefs.h
@@ -324,10 +324,6 @@ struct _WacomChannel
WacomDeviceState work; /* next state */
- /* the following struct contains the current known state of the
- * device channel, as well as the previous MAX_SAMPLES states
- * for use in detecting hardware defects, jitter, trends, etc. */
-
/* the following union contains the current known state of the
* device channel, as well as the previous MAX_SAMPLES states
* for use in detecting hardware defects, jitter, trends, etc. */
--
1.6.5.7
next reply other threads:[~2010-01-04 23:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-04 23:17 Przemysław Firszt [this message]
2010-01-04 23:25 ` [PATCH] Two small patches Peter Hutterer
2010-01-04 23:34 ` Marcel Holtmann
2010-01-07 20:18 ` Przemysław Firszt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1262647038.2983.5.camel@pldmachine \
--to=przemo@firszt.eu \
--cc=linux-bluetooth@vger.kernel.org \
--cc=peter.hutterer@who-t.net \
--cc=pinglinux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.