All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Hutchings <ben-/+tVBieCtBitmTQ+vhA3Yw@public.gmane.org>
To: "David S. Miller" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
Cc: "Rafael J. Wysocki" <rjw-KKrjLPT3xs0@public.gmane.org>,
	netdev <netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Kernel Testers List
	<kernel-testers-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] cdc-ether: Assume link is up initially
Date: Wed, 06 Jan 2010 01:47:15 +0000	[thread overview]
Message-ID: <1262742435.26813.61.camel@localhost> (raw)
In-Reply-To: <1262741203.26813.58.camel@localhost>

[-- Attachment #1: Type: text/plain, Size: 1242 bytes --]

On Wed, 2010-01-06 at 01:26 +0000, Ben Hutchings wrote:
> The bug report <http://bugzilla.kernel.org/show_bug.cgi?id=14791>
> implies that at least some devices will not send a Network Connection
> notification if the link is initially up.  Further, the CDC-ECM
> specification states that '[n]etworking devices are typically "Always
> Connected", spending all of their time with the "link up"'.  So it
> appears to be safer to assume the link is up and to rely on the device
> to tell us otherwise.
> 
> This is a partial revert of:
> 
> commit 37e8273cd30592d3a82bcb70cbb1bdc4eaeb6b71
> Author: Ben Hutchings <ben-/+tVBieCtBitmTQ+vhA3Yw@public.gmane.org>
> Date:   Wed Nov 4 15:29:52 2009 +0000
> 
>     usbnet: Set link down initially for drivers that update link state
> 
> Signed-off-by: Ben Hutchings <ben-/+tVBieCtBitmTQ+vhA3Yw@public.gmane.org>
> Cc: stable-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
> ---
> This should be tested by someone with one of these devices, preferably
> you since you reported the bug.

Mail to reporter bounces, so someone else had better check this.

Ben.

-- 
Ben Hutchings
Horngren's Observation:
                   Among economists, the real world is often a special case.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

  reply	other threads:[~2010-01-06  1:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-06  1:26 [PATCH] cdc-ether: Assume link is up initially Ben Hutchings
2010-01-06  1:47 ` Ben Hutchings [this message]
2010-01-16  9:07   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1262742435.26813.61.camel@localhost \
    --to=ben-/+tvbiectbitmtq+vha3yw@public.gmane.org \
    --cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
    --cc=kernel-testers-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=rjw-KKrjLPT3xs0@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.