From: Mike Galbraith <efault@gmx.de>
To: Lin Ming <ming.m.lin@intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
lkml <linux-kernel@vger.kernel.org>,
"Zhang, Yanmin" <yanmin_zhang@linux.intel.com>
Subject: Re: [RFC PATCH] sched: Pass affine target cpu into wake_affine
Date: Thu, 07 Jan 2010 10:33:27 +0100 [thread overview]
Message-ID: <1262856807.19822.4.camel@marge.simson.net> (raw)
In-Reply-To: <1262853903.18931.17.camel@minggr.sh.intel.com>
On Thu, 2010-01-07 at 16:45 +0800, Lin Ming wrote:
> On Tue, 2010-01-05 at 14:43 +0800, Mike Galbraith wrote:
> > On Tue, 2010-01-05 at 04:44 +0100, Mike Galbraith wrote:
> > > On Tue, 2010-01-05 at 10:48 +0800, Lin Ming wrote:
> > > > On Mon, 2010-01-04 at 17:03 +0800, Lin Ming wrote:
> > > > > commit a03ecf08d7bbdd979d81163ea13d194fe21ad339
> > > > > Author: Lin Ming <ming.m.lin@intel.com>
> > > > > Date: Mon Jan 4 14:14:50 2010 +0800
> > > > >
> > > > > sched: Pass affine target cpu into wake_affine
> > > > >
> > > > > Since commit a1f84a3(sched: Check for an idle shared cache in select_task_rq_fair()),
> > > > > the affine target maybe adjusted to any idle cpu in cache sharing domains
> > > > > instead of current cpu.
> > > > > But wake_affine still use current cpu to calculate load which is wrong.
> > > > >
> > > > > This patch passes affine cpu into wake_affine.
> > > > >
> > > > > Signed-off-by: Lin Ming <ming.m.lin@intel.com>
> > > >
> > > > Mike,
> > > >
> > > > Any comment of this patch?
> > >
> > > The patch definitely looks like the right thing to do, but when I tried
> > > this, it didn't work out well. Since I can't seem to recall precise
> > > details, I'll let my box either remind me or give it's ack.
> >
> > Unfortunately, box reminded me. mysql+oltp peak throughput with
> > nr_clients == nr_cpus
>
> Did you test with your vmark regression fix patch also applied?
Yeah. Delta between tested kernels was your patch.
-Mike
next prev parent reply other threads:[~2010-01-07 9:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-04 9:03 [RFC PATCH] sched: Pass affine target cpu into wake_affine Lin Ming
2010-01-04 9:25 ` Peter Zijlstra
2010-01-04 9:12 ` Lin Ming
2010-01-04 9:32 ` Peter Zijlstra
2010-01-04 10:59 ` Mike Galbraith
2010-01-04 11:07 ` Lin Ming
2010-01-05 2:48 ` Lin Ming
2010-01-05 3:44 ` Mike Galbraith
2010-01-05 6:43 ` Mike Galbraith
2010-01-05 11:49 ` Mike Galbraith
2010-01-07 8:45 ` Lin Ming
2010-01-07 9:15 ` Peter Zijlstra
2010-01-07 9:33 ` Mike Galbraith [this message]
2010-01-07 13:14 ` Mike Galbraith
2010-01-08 2:38 ` Lin Ming
2010-01-08 3:34 ` Mike Galbraith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1262856807.19822.4.camel@marge.simson.net \
--to=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.m.lin@intel.com \
--cc=peterz@infradead.org \
--cc=yanmin_zhang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.