From: Artem Bityutskiy <dedekind1@gmail.com>
To: Peter Horton <zero@colonel-panic.org>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH] UBI fails to initialise in kernel update marker
Date: Sun, 10 Jan 2010 12:13:02 +0200 [thread overview]
Message-ID: <1263118382.7315.148.camel@localhost.localdomain> (raw)
In-Reply-To: <4B49A486.5060402@colonel-panic.org>
On Sun, 2010-01-10 at 09:57 +0000, Peter Horton wrote:
> On 10/01/2010 09:42, Artem Bityutskiy wrote:
> > On Tue, 2010-01-05 at 11:14 +0000, Peter Horton wrote:
> >> The in kernel copy of a volume's update marker is not initialised from the
> >> volume table.
> >>
> >> Signed-off-by: Peter Horton<zero@colonel-panic.org>
> >>
> >> --- linux-2.6.32.orig/drivers/mtd/ubi/vtbl.c 2010-01-05 10:56:13.000000000 +0000
> >> +++ linux-2.6.32/drivers/mtd/ubi/vtbl.c 2010-01-05 10:57:03.000000000 +0000
> >> @@ -566,6 +566,7 @@
> >> vol->reserved_pebs = be32_to_cpu(vtbl[i].reserved_pebs);
> >> vol->alignment = be32_to_cpu(vtbl[i].alignment);
> >> vol->data_pad = be32_to_cpu(vtbl[i].data_pad);
> >> + vol->upd_marker = vtbl[i].upd_marker;
> >> vol->vol_type = vtbl[i].vol_type == UBI_VID_DYNAMIC ?
> >> UBI_DYNAMIC_VOLUME : UBI_STATIC_VOLUME;
> >> vol->name_len = be16_to_cpu(vtbl[i].name_len);
> >
> > Am I right that this means that whole "forbid using volume with
> > unfinished update" functionality has not worked properly? Or I miss
> > something? Looks like I should send this patch to -stable as well.
> >
>
> The in kernel update marker was always clear on reboot, regardless of
> the flag in the volume table. Consequently reading from the volume
> worked after a reboot even after a failed update.
Oh my. This is the second patch which fixes a bad bug in the volume
update code. It seems it was not used much. I personally do not use that
functionality. The previous fix was this:
http://git.infradead.org/ubi-2.6.git/commit/6afaf8a484cbbfd2ccf58a4e5396d1f280469789
Anyway, pushed your patch to ubi-2.6.git/master tree. I'll send it to
Linus later, and to -stable. Thanks.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
prev parent reply other threads:[~2010-01-10 10:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-05 11:14 [PATCH] UBI fails to initialise in kernel update marker Peter Horton
2010-01-10 9:42 ` Artem Bityutskiy
2010-01-10 9:57 ` Peter Horton
2010-01-10 10:13 ` Artem Bityutskiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1263118382.7315.148.camel@localhost.localdomain \
--to=dedekind1@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=zero@colonel-panic.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.