All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: git@vger.kernel.org
Subject: [PATCH 05/18] http.c: mark file-local functions static
Date: Mon, 11 Jan 2010 23:52:48 -0800	[thread overview]
Message-ID: <1263282781-25596-6-git-send-email-gitster@pobox.com> (raw)
In-Reply-To: <1263282781-25596-1-git-send-email-gitster@pobox.com>

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 http.c |   10 ++++++++--
 http.h |    9 ---------
 2 files changed, 8 insertions(+), 11 deletions(-)

diff --git a/http.c b/http.c
index 5c3efb9..deab595 100644
--- a/http.c
+++ b/http.c
@@ -651,7 +651,7 @@ static void closedown_active_slot(struct active_request_slot *slot)
 	slot->in_use = 0;
 }
 
-void release_active_slot(struct active_request_slot *slot)
+static void release_active_slot(struct active_request_slot *slot)
 {
 	closedown_active_slot(slot);
 	if (slot->curl && curl_session_count > min_curl_sessions) {
@@ -834,7 +834,13 @@ int http_get_strbuf(const char *url, struct strbuf *result, int options)
 	return http_request(url, result, HTTP_REQUEST_STRBUF, options);
 }
 
-int http_get_file(const char *url, const char *filename, int options)
+/*
+ * Downloads an url and stores the result in the given file.
+ *
+ * If a previous interrupted download is detected (i.e. a previous temporary
+ * file is still around) the download is resumed.
+ */
+static int http_get_file(const char *url, const char *filename, int options)
 {
 	int ret;
 	struct strbuf tmpfile = STRBUF_INIT;
diff --git a/http.h b/http.h
index f828e1d..5c9441c 100644
--- a/http.h
+++ b/http.h
@@ -81,7 +81,6 @@ extern int start_active_slot(struct active_request_slot *slot);
 extern void run_active_slot(struct active_request_slot *slot);
 extern void finish_active_slot(struct active_request_slot *slot);
 extern void finish_all_active_slots(void);
-extern void release_active_slot(struct active_request_slot *slot);
 
 #ifdef USE_CURL_MULTI
 extern void fill_active_slots(void);
@@ -136,14 +135,6 @@ extern char *get_remote_object_url(const char *url, const char *hex,
 int http_get_strbuf(const char *url, struct strbuf *result, int options);
 
 /*
- * Downloads an url and stores the result in the given file.
- *
- * If a previous interrupted download is detected (i.e. a previous temporary
- * file is still around) the download is resumed.
- */
-int http_get_file(const char *url, const char *filename, int options);
-
-/*
  * Prints an error message using error() containing url and curl_errorstr,
  * and returns ret.
  */
-- 
1.6.6.280.ge295b7.dirty

  parent reply	other threads:[~2010-01-12  7:54 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-12  7:52 [PATCH 00/18] mark file-local symbols static Junio C Hamano
2010-01-12  7:52 ` [PATCH 01/18] bisect.c: mark file-local function static Junio C Hamano
2010-01-12  7:52 ` [PATCH 02/18] builtin-rev-list.c: " Junio C Hamano
2010-01-12  7:52 ` [PATCH 03/18] pretty.c: " Junio C Hamano
2010-01-12  7:52 ` [PATCH 04/18] date.c: " Junio C Hamano
2010-01-12  8:37   ` Johannes Sixt
2010-01-12  9:05     ` Junio C Hamano
2010-01-12  9:43       ` Johannes Sixt
2010-01-12  7:52 ` Junio C Hamano [this message]
2010-01-12  7:52 ` [PATCH 06/18] entry.c: " Junio C Hamano
2010-01-12  7:52 ` [PATCH 07/18] parse-options.c: " Junio C Hamano
2010-01-12  7:52 ` [PATCH 08/18] read-cache.c: mark file-local functions static Junio C Hamano
2010-01-12  7:52 ` [PATCH 09/18] remote-curl.c: mark file-local function static Junio C Hamano
2010-01-12  7:52 ` [PATCH 10/18] quote.c: " Junio C Hamano
2010-01-12  7:52 ` [PATCH 11/18] submodule.c: " Junio C Hamano
2010-01-12  7:52 ` [PATCH 12/18] utf8.c: " Junio C Hamano
2010-01-12  7:52 ` [PATCH 13/18] mailmap.c: remove unused function Junio C Hamano
2010-01-12  7:52 ` [PATCH 14/18] sha1_file.c: " Junio C Hamano
2010-01-12  7:52 ` [PATCH 15/18] strbuf.c: " Junio C Hamano
2010-01-12  7:52 ` [PATCH 16/18] blob.c: " Junio C Hamano
2010-01-12 17:37   ` Daniel Barkalow
2010-01-13  6:56     ` Junio C Hamano
2010-01-12  7:53 ` [PATCH 17/18] object.c: remove unused functions Junio C Hamano
2010-01-12  7:53 ` [PATCH 18/18] symlinks.c: " Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1263282781-25596-6-git-send-email-gitster@pobox.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.