From: Lin Ming <ming.m.lin@intel.com>
To: "Zhang, Rui" <rui.zhang@intel.com>
Cc: Ilia Mirkin <imirkin@alum.mit.edu>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>
Subject: Re: ACPI info has non-printable chars
Date: Wed, 13 Jan 2010 09:19:43 +0800 [thread overview]
Message-ID: <1263345583.3598.58.camel@minggr.sh.intel.com> (raw)
In-Reply-To: <1263344599.12263.2251.camel@rzhang1-desktop>
On Wed, 2010-01-13 at 09:03 +0800, Zhang, Rui wrote:
> CC Lin Ming, the ACPICA expert.
>
> On Wed, 2010-01-13 at 06:15 +0800, Ilia Mirkin wrote:
> > Hi,
> >
> > I just got a new motherboard (GIGABYTE GA-EX58-UD3R) and I'm seeing
> > the following in the kernel log (2.6.31-gentoo-r6, which I believe is
> > basically 2.6.31.6)
> >
> > ...
> > [ 0.000000] ACPI: TAMG 00000000cfee7330 00AE2 (v01 GBT GBT B0
> > 5455312E BG^A^A 53450101)
>
> non-printable chars in Creator ID field.
>
> > ...
> > [ 0.713697] ACPI Warning: Incorrect checksum in table [TAMG] - 9D,
> > should be 9C 20090521 tbutils-246
> >
> > acpidump shows:
> >
> > TAMG @ 0xcfee7330
> > 0000: 54 41 4d 47 e2 0a 00 00 01 9d 47 42 54 20 20 20 TAMG......GBT
> > 0010: 47 42 54 20 20 20 42 30 2e 31 55 54 42 47 01 01 GBT B0.1UTBG..
> > 0020: 01 01 45 53 44 54 3d 20 ef 00 08 00 0f 00 2c 01 ..ESDT= ......,.
> >
> > So those ^A's are really in there, but it's a little annoying (and it
> > causes less to go into binary viewing mode when it shows up in
> > /var/log/messages). Would it be reasonable to add some kind of
> > escaping code for such situations so that it might print like
> > "BG\x01\x01"?
> >
>
> Ming, any comments on this?
Ilia, please try 2.6.32, that we support non-printable characters.
See below commit.
commit cf02cd47d4747abf8ff0617e15fc05a00202e6d5
Author: Bob Moore <robert.moore@intel.com>
Date: Wed Jun 24 11:38:46 2009 +0800
ACPICA: Dump table header - suppress output of non-printable characters
Function acpi_tb_print_table_header. Some ACPI tables contain
non-printable characters in one of the string fields of the the
header - Signature, OemId, OemTableId, or CompilerId. Invalid
characters are replaced by '?'. ACPICA BZ 788.
http://acpica.org/bugzilla/show_bug.cgi?id=788
Signed-off-by: Bob Moore <robert.moore@intel.com>
Signed-off-by: Lin Ming <ming.m.lin@intel.com>
Signed-off-by: Len Brown <len.brown@intel.com>
>
> thanks,
> rui
>
next prev parent reply other threads:[~2010-01-13 1:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-12 22:15 ACPI info has non-printable chars Ilia Mirkin
2010-01-13 1:03 ` Zhang Rui
2010-01-13 1:02 ` Lin Ming
2010-01-13 1:19 ` Lin Ming [this message]
2010-01-13 1:43 ` Ilia Mirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1263345583.3598.58.camel@minggr.sh.intel.com \
--to=ming.m.lin@intel.com \
--cc=imirkin@alum.mit.edu \
--cc=linux-acpi@vger.kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.