All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Glauber <jang@linux.vnet.ibm.com>
To: linux-crypto <linux-crypto@vger.kernel.org>
Subject: vmac test fails on s390
Date: Thu, 14 Jan 2010 15:05:30 +0100	[thread overview]
Message-ID: <1263477930.5880.22.camel@bender> (raw)

Hi,

Jan 14 14:47:38 h42lp52 kernel: alg: hash: Test 1 failed for vmac(aes-s390)
Jan 14 14:47:38 h42lp52 kernel: 00000000: e7 79 33 b7 fd 8a d7 cb

Looking at the digest from the failing test vector:

.digest = "\xcb\xd7\x8a\xfd\xb7\x33\x79\xe7",

the output looks somehow familiar... Maybe a missing endian conversion?
The patch fixes the test for me but it is just a wild guess and maybe
it should be done at another place?

Jan

diff --git a/crypto/vmac.c b/crypto/vmac.c
index 0a9468e..0e23dfb 100644
--- a/crypto/vmac.c
+++ b/crypto/vmac.c
@@ -359,7 +359,7 @@ static u64 l3hash(u64 p1, u64 p2,
 	rl += t;
 	rl += (0 - (rl < t)) & 257;
 	rl += (0 - (rl > p64-1)) & 257;
-	return rl;
+	return le64_to_cpup(&rl);
 }
 
 static void vhash_update(const unsigned char *m,



             reply	other threads:[~2010-01-14 14:05 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-14 14:05 Jan Glauber [this message]
2010-01-17 11:05 ` vmac test fails on s390 Herbert Xu
2010-02-11  3:18   ` [PATCH] to fix " Wang, Shane
2010-02-16 12:39     ` Herbert Xu
2010-02-20  6:29       ` Wang, Shane
2010-02-21  5:32   ` Wang, Shane
     [not found]     ` <20100221182722.GB11951@Chamillionaire.breakpoint.cc>
2010-02-22  3:21       ` Wang, Shane
2010-03-02 13:57         ` Herbert Xu
2010-03-16  5:25           ` Wang, Shane
2010-03-16  5:31             ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1263477930.5880.22.camel@bender \
    --to=jang@linux.vnet.ibm.com \
    --cc=linux-crypto@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.