All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Roel Kluin <roel.kluin@gmail.com>
Cc: linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>
Subject: Re: powerpc: should mem_end be assigned to dt_struct_end in flatten_device_tree()?
Date: Fri, 15 Jan 2010 13:44:00 +1100	[thread overview]
Message-ID: <1263523440.724.375.camel@pasglop> (raw)
In-Reply-To: <4B4FA225.90108@gmail.com>

On Fri, 2010-01-15 at 00:00 +0100, Roel Kluin wrote:
> vi arch/powerpc/kernel/prom_init.c +1961 and note that in
> flatten_device_tree() we do a
> 
>         RELOC(dt_struct_end) = PAGE_ALIGN(mem_start);
> 
> should that maybe be
> 
>         RELOC(dt_struct_end) = PAGE_ALIGN(mem_end);
> 

Nope.

mem_start is a "cursor", it moves as things gets pushed into the flat
device-tree blob. We thus snapshot its value after pushing the last bit
of the structure. mem_end is just the max boundary past which we can no
longer push things.

Cheers,
Ben.

      reply	other threads:[~2010-01-15  2:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-14 23:00 powerpc: should mem_end be assigned to dt_struct_end in flatten_device_tree()? Roel Kluin
2010-01-15  2:44 ` Benjamin Herrenschmidt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1263523440.724.375.camel@pasglop \
    --to=benh@kernel.crashing.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=paulus@samba.org \
    --cc=roel.kluin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.