[Qemu-devel] Re: [PATCH] QMP: Save default control monitor for emitting async events

[Adam Litke <agl@us.ibm.com>]

On Fri, 2010-01-15 at 11:38 -0200, Luiz Capitulino wrote:
> On Thu, 14 Jan 2010 15:20:10 -0600
> Adam Litke <agl@us.ibm.com> wrote:
> 
> > When using a control/QMP monitor in tandem with a regular monitor, asynchronous
> > messages can get lost depending on the order of the QEMU program arguments.
> > QEMU events issued by monitor_protocol_event() always go to cur_mon.  If the
> > user monitor was specified on the command line first (or it has ,default), the
> > message will be directed to the user monitor (not the QMP monitor).
> 
>  I think we have two problems here:
> 
> 1. Async messages are only delivered for the default Monitor, so if the QMP
> Monitor is not the default one it won't get them (not a bug if well
> documented, but it's annoying)
> 
> 2. On a multiple QMP Monitor setup, only one of them will get async messages
> 
>  This patch fixes 1. but the best fix would be to solve both problems,
> as QMP Monitors have to be equally capable IMO.
> 
>  There's an array with all Monitors IIRC, maybe we could loop through it
> and delivery the message to each QMP ones of them?

Sure.  This was the other way I was considering.  I'll spin up a patch
and we can see how it looks.


-- 
Thanks,
Adam