From: Eric Paris <eparis@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, miltonm@austin.ibm.com,
penberg@cs.helsinki.fi, bharata@linux.vnet.ibm.com,
jkosina@suse.cz
Subject: Re: [PATCH] idr: fix idr corruption when id crosses a layer boundary
Date: Fri, 15 Jan 2010 16:32:57 -0500 [thread overview]
Message-ID: <1263591177.14495.7.camel@localhost> (raw)
In-Reply-To: <20100115132432.88037419.akpm@linux-foundation.org>
On Fri, 2010-01-15 at 13:24 -0800, Andrew Morton wrote:
> On Fri, 15 Jan 2010 16:14:50 -0500
> Eric Paris <eparis@redhat.com> wrote:
>
> > inotify has for months been been having problems keeping the fsnotify view of
> > its objects in sync with the idr view of its objects. I discovered this was
> > only ever the case with the 4096th object created.
>
> Neato. Do you think this will help with all the inotify problems
> people have been having?
I do believe it should shut up the inotify WARN() people have been
seeing and the memory leak....
> Do you think this fix should go into 2.6.32.x and earlier?
If someone who really understands the idr and can explain the original
test that was there thinks it right I think it should. It's been broken
and able to produce corruption for a long time.
-Eric
prev parent reply other threads:[~2010-01-15 21:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-15 21:14 [PATCH] idr: fix idr corruption when id crosses a layer boundary Eric Paris
2010-01-15 21:24 ` Andrew Morton
2010-01-15 21:32 ` Eric Paris [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1263591177.14495.7.camel@localhost \
--to=eparis@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=bharata@linux.vnet.ibm.com \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=miltonm@austin.ibm.com \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.