From: Krzysztof Kozlowski <krzk@kernel.org>
To: Pengyu Luo <mitltlatltl@gmail.com>
Cc: andersson@kernel.org, bryan.odonoghue@linaro.org,
conor+dt@kernel.org, devicetree@vger.kernel.org,
dmitry.baryshkov@linaro.org, gregkh@linuxfoundation.org,
hdegoede@redhat.com, heikki.krogerus@linux.intel.com,
ilpo.jarvinen@linux.intel.com, jdelvare@suse.com,
konradybcio@kernel.org, krzk+dt@kernel.org,
linux-arm-msm@vger.kernel.org, linux-hwmon@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
linux-usb@vger.kernel.org, linux@roeck-us.net,
platform-driver-x86@vger.kernel.org, robh@kernel.org,
sre@kernel.org
Subject: Re: [PATCH v2 1/5] dt-bindings: platform: Add Huawei Matebook E Go EC
Date: Mon, 6 Jan 2025 13:29:57 +0100 [thread overview]
Message-ID: <12636552-b644-429b-8be0-44334fae6130@kernel.org> (raw)
In-Reply-To: <20250106080657.240974-1-mitltlatltl@gmail.com>
On 06/01/2025 09:06, Pengyu Luo wrote:
>>> + - const: huawei,gaokun-ec
>>
>> There is no support for gaokun2 here, so I assume you checked and you
>> know these are compatible. What's more, you claim there is a generic
>> piece of hardware called gaokun-ec and everything in this family will be
>> compatible with it. Well, that's my standard disclaimer and disapproval
>> of using generic compatibles.
>>
>> So in general what you want here is *only one* compatible called
>> huawei,gaokun3-ec
>>
>
> I agree with you. If there is a generic rule to follow, I am not familiar
> with this. I have seen some bindings, using like this, so I followed it
> recently.
Generic rule is: wildcards and family names are not allowed. Now what
"generic" means, is different for different devices. If unsure, always
use only device-specific compatibles.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-01-06 12:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-05 17:41 [PATCH v2 0/5] platform: arm64: Huawei Matebook E Go embedded controller Pengyu Luo
2025-01-05 17:41 ` [PATCH v2 1/5] dt-bindings: platform: Add Huawei Matebook E Go EC Pengyu Luo
2025-01-06 7:11 ` Krzysztof Kozlowski
2025-01-06 8:06 ` Pengyu Luo
2025-01-06 12:29 ` Krzysztof Kozlowski [this message]
2025-01-05 17:41 ` [PATCH v2 2/5] platform: arm64: add Huawei Matebook E Go EC driver Pengyu Luo
2025-01-07 12:25 ` Heikki Krogerus
2025-01-07 16:53 ` Pengyu Luo
2025-01-05 17:41 ` [PATCH v2 3/5] usb: typec: ucsi: add Huawei Matebook E Go ucsi driver Pengyu Luo
2025-01-07 12:30 ` Heikki Krogerus
2025-01-07 16:54 ` Pengyu Luo
2025-01-05 17:41 ` [PATCH v2 4/5] power: supply: add Huawei Matebook E Go psy driver Pengyu Luo
2025-01-05 17:41 ` [PATCH v2 5/5] arm64: dts: qcom: gaokun3: Add Embedded Controller node Pengyu Luo
2025-01-09 14:37 ` Konrad Dybcio
2025-01-06 19:27 ` [PATCH v2 0/5] platform: arm64: Huawei Matebook E Go embedded controller Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12636552-b644-429b-8be0-44334fae6130@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jdelvare@suse.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mitltlatltl@gmail.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.