All of lore.kernel.org
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@suse.de>
To: akataria@vmware.com
Cc: Dmitry Torokhov <dtor@vmware.com>,
	VMware PV-Drivers <pv-drivers@vmware.com>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: [Pv-drivers] [PATCH] PVSCSI: fix signedness warning with newer compilers
Date: Tue, 19 Jan 2010 12:08:12 -0600	[thread overview]
Message-ID: <1263924492.4398.5.camel@mulgrave.site> (raw)
In-Reply-To: <1263924273.24149.1.camel@ank32.eng.vmware.com>

On Tue, 2010-01-19 at 10:04 -0800, Alok Kataria wrote:
> On Tue, 2010-01-19 at 09:38 -0800, Dmitry Torokhov wrote:
> > pvscsi_setup_msix() expects 'irq' argument to be an int but is being
> > passed unsigned int. Unsigned int is more proper type for IRQ number
> > so let's use it. This shuts off a compile warning with recent
> > compilers.
> > 
> > Signed-off-by: Dmitry Torokhov <dtor@vmware.com>
> 
> LGTM.
> 
> Signed-off-by: Alok N Kataria <akataria@vmware.com>

That would be acked-by unless you want to resend the patch to me?  I
don't have an unmangled copy of it, so someone needs to send it to the
scsi list.

Thanks,

James



  reply	other threads:[~2010-01-19 18:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20100119173819.GA28630@dtor-ws.eng.vmware.com>
2010-01-19 18:04 ` [Pv-drivers] [PATCH] PVSCSI: fix signedness warning with newer compilers Alok Kataria
2010-01-19 18:08   ` James Bottomley [this message]
2010-01-19 18:19     ` Alok Kataria
2010-01-19 18:20       ` Dmitry Torokhov
2010-01-19 18:23         ` James Bottomley
2010-01-19 18:27           ` Dmitry Torokhov
2010-01-19 18:26       ` James Bottomley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1263924492.4398.5.camel@mulgrave.site \
    --to=james.bottomley@suse.de \
    --cc=akataria@vmware.com \
    --cc=dtor@vmware.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=pv-drivers@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.