From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: David Miller <davem@davemloft.net>
Cc: "Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
"sri@us.ibm.com" <sri@us.ibm.com>,
"herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next-2.6] IFix IPv6 GSO type checks in Intel ethernet drivers
Date: Tue, 19 Jan 2010 15:15:45 -0800 [thread overview]
Message-ID: <1263942945.17501.1.camel@localhost> (raw)
In-Reply-To: <20100119.141438.266557246.davem@davemloft.net>
On Tue, 2010-01-19 at 15:14 -0700, David Miller wrote:
> From: "Brandeburg, Jesse" <jesse.brandeburg@intel.com>
> Date: Tue, 19 Jan 2010 13:11:00 -0800 (Pacific Standard Time)
>
> >
> >
> > On Tue, 19 Jan 2010, Sridhar Samudrala wrote:
> >
> >> Found this problem when testing IPv6 from a KVM guest to a remote
> >> host via e1000e device on the host.
> >> The following patch fixes the check for IPv6 GSO packet in Intel
> >> ethernet drivers to use skb_is_gso_v6(). SKB_GSO_DODGY is also set
> >> when packets are forwarded from a guest.
> >>
> >> Signed-off-by: Sridhar Samudrala <sri@us.ibm.com
> >
> > Looks fine, thanks! The current code in net-next and 2.6.32 both have
> > exactly the same condition in skb_is_gso_v6, so I'm not sure that this
> > patch alone will fix any issues, FYI. If this patch is part of another
> > set or dependent upon another for the actual change in behavior mentioned
> > in the comment, I think it should be noted or sent in a series.
> >
> > Ack-ed by: Jesse Brandeburg <jesse.brandeburg@intel.com>
>
> Just FYI, I'm assuming I'll get this via Jeff eventually.
Correct, I will add this patch to my queue of patches.
Cheers,
Jeff
next prev parent reply other threads:[~2010-01-19 23:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-19 21:02 [PATCH net-next-2.6] IFix IPv6 GSO type checks in Intel ethernet drivers Sridhar Samudrala
2010-01-19 21:11 ` Brandeburg, Jesse
2010-01-19 22:14 ` David Miller
2010-01-19 23:15 ` Jeff Kirsher [this message]
2010-01-19 22:36 ` Sridhar Samudrala
2010-01-19 22:39 ` Herbert Xu
2010-01-20 0:44 ` Equal cost multipath for IPv6? Templin, Fred L
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1263942945.17501.1.camel@localhost \
--to=jeffrey.t.kirsher@intel.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=jesse.brandeburg@intel.com \
--cc=netdev@vger.kernel.org \
--cc=sri@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.