From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alberto Panizzo Subject: [PATCH] spi: spi_imx: add device information to debug. Date: Wed, 20 Jan 2010 10:47:14 +0100 Message-ID: <1263980834.3083.18.camel@realization> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: linux-kernel , Andrew Morton , Uwe =?ISO-8859-1?Q?Kleine-K=F6nig?= To: spi-devel-list Return-path: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org SGkgYWxsIQpJIGFscmVhZHkgc2VudCB0aGlzIHBhdGNoIHRvIHRoZSBsaW51eC1hcm0ta2VybmVs IG1haWxpbmcgbGlzdCwKYnV0IG5vdCBjYyB5b3UuCkluIHJlZmVyZW5jZSB0bzoKaHR0cDovL3Ro cmVhZC5nbWFuZS5vcmcvZ21hbmUubGludXgucG9ydHMuYXJtLmtlcm5lbC83MTExOQoKUGF0Y2gg YmVsb3c6CnRoaXMgcGF0Y2ggYXBwbHkgdG8gIGxpbnVzIC4zMy1yYzQgCi0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQpOb3QgYW4g aGVhdnkgZml4LCBidXQgZ29vZCB3aGVuIGRlYnVnZ2luZyBtdWx0aXBsZSBzcGkgY2hhbm5lbHMu CgpTaWduZWQtb2ZmLWJ5OiBBbGJlcnRvIFBhbml6em8gPG1hcmFtYW9wZXJjaGVzZWltb3J0b0Bn bWFpbC5jb20+CkFja2VkLWJ5OiBVd2UgS2xlaW5lLUvDtm5pZyA8dS5rbGVpbmUta29lbmlnQHBl bmd1dHJvbml4LmRlPgotLS0KIGRyaXZlcnMvc3BpL3NwaV9pbXguYyB8ICAgIDIgKy0KIDEgZmls ZXMgY2hhbmdlZCwgMSBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBh L2RyaXZlcnMvc3BpL3NwaV9pbXguYyBiL2RyaXZlcnMvc3BpL3NwaV9pbXguYwppbmRleCA4OWMy MmVmLi4xOGJiZmEzIDEwMDY0NAotLS0gYS9kcml2ZXJzL3NwaS9zcGlfaW14LmMKKysrIGIvZHJp dmVycy9zcGkvc3BpX2lteC5jCkBAIC00NjYsNyArNDY2LDcgQEAgc3RhdGljIGludCBzcGlfaW14 X3NldHVwKHN0cnVjdCBzcGlfZGV2aWNlICpzcGkpCiAgICAgICAgc3RydWN0IHNwaV9pbXhfZGF0 YSAqc3BpX2lteCA9IHNwaV9tYXN0ZXJfZ2V0X2RldmRhdGEoc3BpLT5tYXN0ZXIpOwogICAgICAg IGludCBncGlvID0gc3BpX2lteC0+Y2hpcHNlbGVjdFtzcGktPmNoaXBfc2VsZWN0XTsKIAotICAg ICAgIHByX2RlYnVnKCIlczogbW9kZSAlZCwgJXUgYnB3LCAlZCBoelxuIiwgX19mdW5jX18sCisg ICAgICAgZGV2X2RiZygmc3BpLT5kZXYsICIlczogbW9kZSAlZCwgJXUgYnB3LCAlZCBoelxuIiwg X19mdW5jX18sCiAgICAgICAgICAgICAgICAgc3BpLT5tb2RlLCBzcGktPmJpdHNfcGVyX3dvcmQs IHNwaS0+bWF4X3NwZWVkX2h6KTsKIAogICAgICAgIGlmIChncGlvID49IDApCi0tIAoxLjYuMy4z CgoKCi0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQpUaHJvdWdob3V0IGl0cyAxOC15ZWFyIGhpc3Rvcnks IFJTQSBDb25mZXJlbmNlIGNvbnNpc3RlbnRseSBhdHRyYWN0cyB0aGUKd29ybGQncyBiZXN0IGFu ZCBicmlnaHRlc3QgaW4gdGhlIGZpZWxkLCBjcmVhdGluZyBvcHBvcnR1bml0aWVzIGZvciBDb25m ZXJlbmNlCmF0dGVuZGVlcyB0byBsZWFybiBhYm91dCBpbmZvcm1hdGlvbiBzZWN1cml0eSdzIG1v c3QgaW1wb3J0YW50IGlzc3VlcyB0aHJvdWdoCmludGVyYWN0aW9ucyB3aXRoIHBlZXJzLCBsdW1p bmFyaWVzIGFuZCBlbWVyZ2luZyBhbmQgZXN0YWJsaXNoZWQgY29tcGFuaWVzLgpodHRwOi8vcC5z Zi5uZXQvc2Z1L3JzYWNvbmYtZGV2MmRldgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpzcGktZGV2ZWwtZ2VuZXJhbCBtYWlsaW5nIGxpc3QKc3BpLWRldmVs LWdlbmVyYWxAbGlzdHMuc291cmNlZm9yZ2UubmV0Cmh0dHBzOi8vbGlzdHMuc291cmNlZm9yZ2Uu bmV0L2xpc3RzL2xpc3RpbmZvL3NwaS1kZXZlbC1nZW5lcmFsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752616Ab0ATJrX (ORCPT ); Wed, 20 Jan 2010 04:47:23 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752448Ab0ATJrW (ORCPT ); Wed, 20 Jan 2010 04:47:22 -0500 Received: from mail-fx0-f225.google.com ([209.85.220.225]:39493 "EHLO mail-fx0-f225.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751999Ab0ATJrV (ORCPT ); Wed, 20 Jan 2010 04:47:21 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:to:cc:content-type:date:message-id:mime-version :x-mailer:content-transfer-encoding; b=UVFQ00X2ehDymdJQaMqWW2fRh78YbPCaIyEfySHuIl2iR2Wbd+03ZTmodb2/2D3dCm kC2DeMgujLqrs8TiphLe1UGKiyHHZ9hRCR8NgYWmze/102asRG5Yp7+pR91YYJNLb0ii xvl0j+5W+CQL+946baFa93u+66N6rUn5n9AJQ= Subject: [PATCH] spi: spi_imx: add device information to debug. From: Alberto Panizzo To: spi-devel-list Cc: Grant Likely , Andrew Morton , Uwe =?ISO-8859-1?Q?Kleine-K=F6nig?= , Sascha linux-arm , linux-kernel Content-Type: text/plain; charset="UTF-8" Date: Wed, 20 Jan 2010 10:47:14 +0100 Message-ID: <1263980834.3083.18.camel@realization> Mime-Version: 1.0 X-Mailer: Evolution 2.28.1 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi all! I already sent this patch to the linux-arm-kernel mailing list, but not cc you. In reference to: http://thread.gmane.org/gmane.linux.ports.arm.kernel/71119 Patch below: this patch apply to linus .33-rc4 --------------------------------------------------------------- Not an heavy fix, but good when debugging multiple spi channels. Signed-off-by: Alberto Panizzo Acked-by: Uwe Kleine-König --- drivers/spi/spi_imx.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/spi/spi_imx.c b/drivers/spi/spi_imx.c index 89c22ef..18bbfa3 100644 --- a/drivers/spi/spi_imx.c +++ b/drivers/spi/spi_imx.c @@ -466,7 +466,7 @@ static int spi_imx_setup(struct spi_device *spi) struct spi_imx_data *spi_imx = spi_master_get_devdata(spi->master); int gpio = spi_imx->chipselect[spi->chip_select]; - pr_debug("%s: mode %d, %u bpw, %d hz\n", __func__, + dev_dbg(&spi->dev, "%s: mode %d, %u bpw, %d hz\n", __func__, spi->mode, spi->bits_per_word, spi->max_speed_hz); if (gpio >= 0) -- 1.6.3.3