From: Steven Rostedt <rostedt@goodmis.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Kei Tokunaga <tokunaga.keiich@jp.fujitsu.com>,
linux-scsi@vger.kernel.org,
James Bottomley <James.Bottomley@suse.de>,
Ingo Molnar <mingo@redhat.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
lkml <linux-kernel@vger.kernel.org>,
Li Zefan <lizf@cn.fujitsu.com>,
Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>,
Tomohiro Kusumi <kusumi.tomohiro@jp.fujitsu.com>
Subject: Re: [PATCH 2/2] scsi: add scsi trace core function and put trace points
Date: Wed, 20 Jan 2010 12:42:19 -0500 [thread overview]
Message-ID: <1264009339.4561.56.camel@frodo> (raw)
In-Reply-To: <20100120083741.GA5020@infradead.org>
On Wed, 2010-01-20 at 03:37 -0500, Christoph Hellwig wrote:
> > --- linux-2.6.33-rc4-trace/kernel/trace/Makefile~scsi_trace 2010-01-18 16:23:16.000000000 +0900
> > +++ linux-2.6.33-rc4-trace-kei/kernel/trace/Makefile 2010-01-18 16:23:16.000000000 +0900
> > @@ -48,6 +48,9 @@ obj-$(CONFIG_BLK_DEV_IO_TRACE) += blktra
> > ifeq ($(CONFIG_BLOCK),y)
> > obj-$(CONFIG_EVENT_TRACING) += blktrace.o
> > endif
> > +ifneq ($(CONFIG_SCSI),)
> > +obj-$(CONFIG_EVENT_TRACING) += scsitrace.o
> > +endif
> > obj-$(CONFIG_EVENT_TRACING) += trace_events.o
> > obj-$(CONFIG_EVENT_TRACING) += trace_export.o
> > obj-$(CONFIG_FTRACE_SYSCALLS) += trace_syscalls.o
>
> The code should be built into scsi_mod.ko and thus from drivers/scsi/
>
Yes, none of this code belongs in kernel/trace/.
-- Steve
next prev parent reply other threads:[~2010-01-20 17:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-20 6:43 [PATCH 2/2] scsi: add scsi trace core function and put trace points Kei Tokunaga
2010-01-20 7:58 ` Martin K. Petersen
2010-01-20 8:38 ` Christoph Hellwig
2010-02-01 4:43 ` Kei Tokunaga
2010-01-20 8:37 ` Christoph Hellwig
2010-01-20 17:42 ` Steven Rostedt [this message]
2010-02-01 4:45 ` Kei Tokunaga
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1264009339.4561.56.camel@frodo \
--to=rostedt@goodmis.org \
--cc=James.Bottomley@suse.de \
--cc=fweisbec@gmail.com \
--cc=hch@infradead.org \
--cc=kusumi.tomohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=mingo@redhat.com \
--cc=tokunaga.keiich@jp.fujitsu.com \
--cc=xiaoguangrong@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.