Re: [PATCH] DSPBRIDGE: Various compile warning fixes

[Ameya Palande <ameya.palande@nokia.com>]

On Thu, 2010-01-21 at 17:01 +0100, ext Andy Shevchenko wrote:
> On Thu, Jan 21, 2010 at 3:40 PM, Ameya Palande <ameya.palande@nokia.com> wrote:
> > --- a/drivers/dsp/bridge/wmd/io_sm.c
> > +++ b/drivers/dsp/bridge/wmd/io_sm.c
> > @@ -1210,7 +1210,7 @@ static void InputChnl(struct IO_MGR *pIOMgr, struct CHNL_OBJECT *pChnl,
> >                            pChnlMgr->uWordSize;
> >        chnlId = IO_GetValue(pIOMgr->hWmdContext, struct SHM, sm, inputId);
> >        dwArg = IO_GetLong(pIOMgr->hWmdContext, struct SHM, sm, arg);
> > -       if (!(chnlId >= 0) || !(chnlId < CHNL_MAXCHANNELS)) {
> > +       if (chnlId >= CHNL_MAXCHANNELS) {
> Could chnlld be less than zero? Anyway better to test:
> (chnlId >= CHNL_MAXCHANNELS || chnlld < 0)
> 

chnlId is defined as u32 ;)

Cheers,
Ameya.