All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefani Seibold <stefani@seibold.net>
To: Thiago Farina <tfransosi@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Andi Kleen <ak@linux.intel.com>,
	Greg Kroah-Hartman <gregkh@suse.de>,
	Mauro Carvalho Chehab <mchehab@redhat.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] kernel/kfifo.c: fix "interger as NULL pointer" warning.
Date: Sun, 24 Jan 2010 18:15:24 +0100	[thread overview]
Message-ID: <1264353324.5592.1.camel@wall-e> (raw)
In-Reply-To: <1264349038-1766-1-git-send-email-tfransosi@gmail.com>

Am Sonntag, den 24.01.2010, 11:03 -0500 schrieb Thiago Farina:
> kernel/kfifo.c:83:35: warning: Using plain integer as NULL pointer
> 

I don't know where you get this kind of warning. But passing 0 for a
NULL pointer is ANSI C standard.

> Signed-off-by: Thiago Farina <tfransosi@gmail.com>
> ---
>  kernel/kfifo.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/kernel/kfifo.c b/kernel/kfifo.c
> index 32c5c15..6fe4a56 100644
> --- a/kernel/kfifo.c
> +++ b/kernel/kfifo.c
> @@ -80,7 +80,7 @@ int kfifo_alloc(struct kfifo *fifo, unsigned int size, gfp_t gfp_mask)
>  
>  	buffer = kmalloc(size, gfp_mask);
>  	if (!buffer) {
> -		_kfifo_init(fifo, 0, 0);
> +		_kfifo_init(fifo, NULL, 0);
>  		return -ENOMEM;
>  	}
>  



  parent reply	other threads:[~2010-01-24 17:15 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-24 16:03 [PATCH 1/4] kernel/kfifo.c: fix "interger as NULL pointer" warning Thiago Farina
2010-01-24 16:03 ` [PATCH 2/4] kernel/test_kprobes.c: fix "integer " Thiago Farina
2010-01-24 16:03 ` [PATCH 3/4] trace/trace_output.c: " Thiago Farina
2010-01-25 21:40   ` Steven Rostedt
2010-05-05 15:59     ` Steven Rostedt
2010-05-07 18:40   ` [tip:tracing/core] tracing: Fix " tip-bot for Thiago Farina
2010-01-24 16:03 ` [PATCH 4/4] mm/memcontrol.c: fix " Thiago Farina
2010-01-24 16:03   ` Thiago Farina
2010-01-24 20:50   ` Balbir Singh
2010-01-24 20:50     ` Balbir Singh
2010-01-24 17:15 ` Stefani Seibold [this message]
2010-01-24 18:54   ` [PATCH 1/4] kernel/kfifo.c: fix "interger " Thiago Farina
2010-01-25 10:11   ` Andi Kleen
2010-01-27  1:39   ` Thiago Farina
2010-01-27  6:44     ` Stefani Seibold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1264353324.5592.1.camel@wall-e \
    --to=stefani@seibold.net \
    --cc=ak@linux.intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab@redhat.com \
    --cc=tfransosi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.