From: Dave Airlie <airlied@redhat.com>
To: Zhenyu Wang <zhenyuw@linux.intel.com>
Cc: dri-devel@lists.sourceforge.net
Subject: Re: [PATCH] drm: fix regression in fb blank handling
Date: Mon, 25 Jan 2010 16:29:06 +1000 [thread overview]
Message-ID: <1264400946.8478.2.camel@localhost> (raw)
In-Reply-To: <20100121010916.GA13214@zhen-devel.sh.intel.com>
On Thu, 2010-01-21 at 09:09 +0800, Zhenyu Wang wrote:
> On 2010.01.20 13:14:23 +0000, James Simmons wrote:
> >
> > It's just adding the backlight api to the intel driver. In fact it gives
> > the user the ablity to control the brightness of the backlight which I see
> > is lacking in the intel driver.
>
> Wait, this regression has nothing to do with backlight control. We already
> have backlight drivers for platform specific or ACPI interface, the reason
> intel driver doesn't hook up one is because if we provide native interface
> which would be much possible to have state conflict with platform or ACPI way.
>
> This problem is just the wrong DPMS state is used for FB blank request.
> Dave, does my patch look sane? This regression isn't in 2.6.32, but only
> for .33-rc kernel.
We should revisit this for 2.6.34, but for now I've applied Zhenyu's
patch until we can figure out where the problems are, as it breaks a few
too many laptops at this stage for 2.6.33.
Dave.
>
------------------------------------------------------------------------------
Throughout its 18-year history, RSA Conference consistently attracts the
world's best and brightest in the field, creating opportunities for Conference
attendees to learn about information security's most important issues through
interactions with peers, luminaries and emerging and established companies.
http://p.sf.net/sfu/rsaconf-dev2dev
--
next prev parent reply other threads:[~2010-01-25 6:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-18 8:47 [PATCH] drm: fix regression in fb blank handling Zhenyu Wang
2010-01-18 13:30 ` James Simmons
2010-01-19 1:01 ` Zhenyu Wang
2010-01-19 16:17 ` James Simmons
2010-01-20 2:54 ` Zhenyu Wang
2010-01-20 13:14 ` James Simmons
2010-01-21 1:09 ` Zhenyu Wang
2010-01-25 6:29 ` Dave Airlie [this message]
2010-01-25 18:12 ` James Simmons
2010-01-26 1:09 ` Zhenyu Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1264400946.8478.2.camel@localhost \
--to=airlied@redhat.com \
--cc=dri-devel@lists.sourceforge.net \
--cc=zhenyuw@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.