All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: ofono@ofono.org
Subject: Re: [PATCH 0/6] STE-plugin
Date: Mon, 25 Jan 2010 21:07:21 +0100	[thread overview]
Message-ID: <1264450041.11653.18.camel@violet> (raw)
In-Reply-To: <1264447534-2386-1-git-send-email-sjur.brandeland@stericsson.com>

[-- Attachment #1: Type: text/plain, Size: 914 bytes --]

Hi Sjur,

> This is a new version of the STE-plugin patch set. Since last RFCv2 we have
> stubbed out Voice Call and GPRS Context handling, changed patch order,
> cleanup some unnecessary includes, moved CAIF header files, and fixed 
> most other review comments (hopefully).

I applied all of your 6 patches. However there were some issues with
your submission.

First, please make sure you have a proper .gitconfig with your email
address and author set correct. That way we keep the GIT history clean
and readable. I had to fix this up on all your patches.

Second, please do proper commit messages. Either one line describes what
your are doing (will end up as Subject) or one line and then a body
describing the details. Check the GIT history for examples.

Third, please ensure that "make distcheck" builds properly. I had to fix
it up for the CAIF header files.

Regards

Marcel



      parent reply	other threads:[~2010-01-25 20:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-25 19:25 [PATCH 0/6] STE-plugin sjur.brandeland
2010-01-25 19:25 ` [PATCH 1/6] STE-plugin: Add at_util_call_compare_by_id sjur.brandeland
2010-01-25 19:25   ` [PATCH 2/6] STE-plugin: Add vendor STE and quirks in atmodem sjur.brandeland
2010-01-25 19:25     ` [PATCH 3/6] STE-plugin: STE modem driver definition sjur.brandeland
2010-01-25 19:25       ` [PATCH 4/6] STE-plugin: Add CAIF header files in drivers/stemodem sjur.brandeland
2010-01-25 19:25         ` [PATCH 5/6] STE-plugin: Add STE plugin sjur.brandeland
2010-01-25 19:25           ` [PATCH 6/6] STE-plugin: Add STE to Makefile sjur.brandeland
2010-01-25 20:07 ` Marcel Holtmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1264450041.11653.18.camel@violet \
    --to=marcel@holtmann.org \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.