Re: [PATCH] Add type of locks to lock trace events

[Peter Zijlstra <peterz@infradead.org>]

On Tue, 2010-01-26 at 14:56 +0900, Hitoshi Mitake wrote:
> # Sorry, I wrote wrong Cc address. Previous mail was rejected by mailer-daemon.
> # This is second time sending, if you already received this, please discard it...
> 
> There's no need to add any member to lockdep_map
> for adding information of type of locks to lock trace events.
> 
> Example of perf trace:
> |       init-0     [001]   335.078670: lock_acquired: 0xffff8800059d6bd8 &rq->lock kernel/lockdep.c:2973 (0 ns)
> |       rb_consumer-424   [001]   335.078673: lock_acquire: 0xffff8800059d6bd8 1 &rq->lock kernel/lockdep.c:2973
> |                                                                            # ^ &rq->lock is spin lock!
> |       rb_consumer-424   [001]   335.078677: lock_acquire: 0xffff8800bba5e8e8 1 buffer->reader_lock_key kernel/trace/ring_
> |       rb_consumer-424   [001]   335.078679: lock_acquired: 0xffff8800bba5e8e8 buffer->reader_lock_key kernel/trace/ring_b
> |       rb_consumer-424   [001]   335.078684: lock_acquire: 0xffff8800059d12e8 1 &q->lock kernel/smp.c:83
> 
> Of course, as you told, type of lock dealing with is clear for human.
> But it is not clear for programs like perf lock.
> 
> What I want to do is limiting types of lock focus on.
> e.g. perf lock prof --type spin,rwlock
> 
> How do you think, Peter?

I still don't see the use for it, surely you're going to be familiar
with the code if you're looking at lock statistics?