Re: [PATCH 1/3] MIPS: AR7 whitespace hacking

[Wu Zhangjin <wuzhangjin@gmail.com>]

On Sun, 2010-01-31 at 19:38 +0000, Alexander Clouter wrote:
> MIPS: AR7 whitespace hacking
> 
> Signed-off-by: Alexander Clouter <alex@digriz.org.uk>
[...]
>  void __init prom_free_prom_memory(void)
> diff --git a/arch/mips/ar7/platform.c b/arch/mips/ar7/platform.c
> index c591f69..76a358e 100644
> --- a/arch/mips/ar7/platform.c
> +++ b/arch/mips/ar7/platform.c
> @@ -42,39 +42,42 @@
>  #include <asm/mach-ar7/gpio.h>
>  #include <asm/mach-ar7/prom.h>
>  
> +/*****************************************************************************
> + * VLYNQ Bus
> + ****************************************************************************/

Why not simply use:

/* VLYNQ Bus */

You have deleted lots of whitespaces, but added more *.

[...]
> +/*****************************************************************************
> + * Flash
> + ****************************************************************************/
[...]
> +
> +/*****************************************************************************
> + * Ethernet
> + ****************************************************************************/
[...]
> +
> +/*****************************************************************************
> + * USB
> + ****************************************************************************/
> +
[...]
>  
> +/*****************************************************************************
> + * LEDs
> + ****************************************************************************/
[...]
> +/*****************************************************************************
> + * Watchdog
> + ****************************************************************************/
[...]
> +
> +/*****************************************************************************
> + * Init
> + ****************************************************************************/
[...]
>  
> @@ -70,7 +71,6 @@ console_initcall(ar7_init_console);
>   * Initializes basic routines and structures pointers, memory size (as
>   * given by the bios and saves the command line.
>   */
> -
>  void __init plat_mem_setup(void)
>  {
>  	unsigned long io_base;
> @@ -88,6 +88,5 @@ void __init plat_mem_setup(void)
>  	prom_meminit();
>  
>  	printk(KERN_INFO "%s, ID: 0x%04x, Revision: 0x%02x\n",
> -					get_system_type(),
> -		ar7_chip_id(), ar7_chip_rev());
> +			get_system_type(), ar7_chip_id(), ar7_chip_rev());
>  }

Perhaps you can use pr_info() instead of printk(KERN_INFO) too, of
course, if there are more printk(KERN_...), you can replace them by
pr_xxx defined in include/linux/kernel.h

Best Regards,
	Wu Zhangjin