From: Wu Zhangjin <wuzhangjin@gmail.com>
To: mbizon@freebox.fr
Cc: David VomLehn <dvomlehn@cisco.com>,
linux-mips@linux-mips.org, ralf@linux-mips.org
Subject: Re: [PATCH] powertv: Fix support for timer interrupts when using >64 external IRQs
Date: Mon, 01 Feb 2010 16:47:56 +0800 [thread overview]
Message-ID: <1265014076.14427.1.camel@falcon> (raw)
In-Reply-To: <1264864218.32192.1.camel@sakura.staff.proxad.net>
On Sat, 2010-01-30 at 16:10 +0100, Maxime Bizon wrote:
> On Mon, 2009-12-21 at 17:49 -0800, David VomLehn wrote:
>
> Hi,
>
> > if (cpu_has_mips_r2) {
> > - cp0_compare_irq = (read_c0_intctl() >> 29) & 7;
> > - cp0_perfcount_irq = (read_c0_intctl() >> 26) & 7;
> > + cp0_compare_irq_shift = CAUSEB_TI - CAUSEB_IP;
> > + cp0_compare_irq = (read_c0_intctl() >> INTCTLB_IPTI) & 7;
> > + cp0_perfcount_irq = (read_c0_intctl() >> INTCTLB_IPPCI) & 7;
>
> This patch breaks at least bcm63xx, because cp0_compare_irq_shift is not
> initialized when cpu_has_mips_r2 is false.
Yes, that patch have broken the CEVT_R4K support in the archs whose
cpu_has_mips_r2 is false.
I will send a piece of patch to fix it.
Thanks & Regards,
Wu Zhangjin
prev parent reply other threads:[~2010-02-01 8:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-22 1:49 [PATCH] powertv: Fix support for timer interrupts when using >64 external IRQs David VomLehn
2010-01-26 14:26 ` Ralf Baechle
2010-01-26 18:36 ` David VomLehn
2010-01-26 23:20 ` Ralf Baechle
2010-01-30 15:10 ` Maxime Bizon
2010-02-01 8:47 ` Wu Zhangjin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1265014076.14427.1.camel@falcon \
--to=wuzhangjin@gmail.com \
--cc=dvomlehn@cisco.com \
--cc=linux-mips@linux-mips.org \
--cc=mbizon@freebox.fr \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.