Re: [PATCH 1/2] Fix: Username and Password must be set after context is created.

[Marcel Holtmann <marcel@holtmann.org>]

[-- Attachment #1: Type: text/plain, Size: 1075 bytes --]

Hi Denis,

> > > > And we might wanna check if MBM cards behave similar and ensure that
> > > > STE and MBM cards use a similar code flow.
> > >
> > > When testing this EIAAUW fails if there are no prior PDP context on the
> > > modem. Most likely this is the case with the MBM module as well, but I
> > > have not tested this.
> > 
> > Then we have to do that in the callback in an extra step. I don't really
> > like it, but seems the way to go. Please send a patch that also changes
> > this for MBM devices. We really wanna keep these in sync.
> 
> Actually the easiest way to do this is simply queue the EIAAUW after the 
> CGDCONT in activate_context.  If CGDCONT fails then EIAAUW won't have any 
> effect anyway (but will get executed nevertheless).  This is better than 
> worrying about strduping username/password and freeing it in all possible code 
> paths.

sounds good enough to me. Just wanna have STE and MBM in sync here. And
of course an extra comment that explain why we do it.

Sjur, care to send a patch?

Regards

Marcel