From: linux@audioscience.com
To: patch@alsa-project.org
Cc: tiwai@suse.de,
Eliot Blennerhassett <eblennerhassett@audioscience.com>,
alsa-devel@alsa-project.org
Subject: [PATCH] Make firmware vs driver major version mismatch an error.
Date: Wed, 03 Feb 2010 10:07:37 +1300 [thread overview]
Message-ID: <1265144857-13808-1-git-send-email-linux@audioscience.com> (raw)
From: Eliot Blennerhassett <eblennerhassett@audioscience.com>
I.e. incompatible firmware will fail driver load.
Signed-off-by: Eliot Blennerhassett <eblennerhassett@audioscience.com>
---
pci/asihpi/hpidspcd.c | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/pci/asihpi/hpidspcd.c b/pci/asihpi/hpidspcd.c
index 8c0f251..f58d5a0 100644
--- a/pci/asihpi/hpidspcd.c
+++ b/pci/asihpi/hpidspcd.c
@@ -103,6 +103,13 @@ short HpiDspCode_Open(
goto error2;
}
+ if (header.version / 10000 != HPI_VER_DECIMAL / 10000) {
+ HPI_DEBUG_LOG(ERROR,
+ "Firmware Major Version mismatch DSP image %d != Driver %d\n",
+ header.version, HPI_VER_DECIMAL);
+ goto error2;
+ }
+
if (header.version != HPI_VER_DECIMAL) {
HPI_DEBUG_LOG(WARNING,
"Version mismatch DSP image %d != Driver %d\n",
--
1.7.0.rc0.8.ge3f67d
next reply other threads:[~2010-02-02 21:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-02 21:07 linux [this message]
2010-02-02 21:42 ` [PATCH] Make firmware vs driver major version mismatch an error Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1265144857-13808-1-git-send-email-linux@audioscience.com \
--to=linux@audioscience.com \
--cc=alsa-devel@alsa-project.org \
--cc=eblennerhassett@audioscience.com \
--cc=patch@alsa-project.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.