From: "Stanley.Miao" <stanley.miao@windriver.com>
To: linux-mtd@lists.infradead.org
Subject: [PATCH 5/5] Place the cleanmarker in OOB area according to the mode MTD_OOB_AUTO
Date: Wed, 3 Feb 2010 10:56:36 +0800 [thread overview]
Message-ID: <1265165796-24686-6-git-send-email-stanley.miao@windriver.com> (raw)
In-Reply-To: <1265165796-24686-5-git-send-email-stanley.miao@windriver.com>
In the current linux kernel, Jffs2 writes the cleanmarker according to the
mode MTD_OOB_AUTO, so modify the layout of the cleanmarker from
MTD_OOB_PLACE to MTD_OOB_AUTO in flash_eraseall.
Signed-off-by: Stanley.Miao <stanley.miao@windriver.com>
---
flash_eraseall.c | 38 ++++++++++++++++++++------------------
1 files changed, 20 insertions(+), 18 deletions(-)
diff --git a/flash_eraseall.c b/flash_eraseall.c
index 1842906..d2d0bcb 100644
--- a/flash_eraseall.c
+++ b/flash_eraseall.c
@@ -34,7 +34,7 @@
#include <time.h>
#include <getopt.h>
#include <sys/ioctl.h>
-#include <sys/mount.h>
+#include <sys/param.h>
#include "crc32.h"
#include <mtd/mtd-user.h>
@@ -58,9 +58,11 @@ int target_endian = __BYTE_ORDER;
int main (int argc, char *argv[])
{
mtd_info_t meminfo;
- int fd, clmpos = 0, clmlen = 8;
+ int fd;
erase_info_t erase;
int isNAND, bbtest = 1;
+ unsigned char oobbuf[128];
+ memset(oobbuf, 0xFF, 128);
process_options(argc, argv);
@@ -81,29 +83,29 @@ int main (int argc, char *argv[])
if (jffs2) {
cleanmarker.magic = cpu_to_je16 (JFFS2_MAGIC_BITMASK);
cleanmarker.nodetype = cpu_to_je16 (JFFS2_NODETYPE_CLEANMARKER);
- if (!isNAND)
+ if (!isNAND) {
cleanmarker.totlen = cpu_to_je32 (sizeof (struct jffs2_unknown_node));
- else {
+ cleanmarker.hdr_crc = cpu_to_je32(crc32(0, &cleanmarker, sizeof(struct jffs2_unknown_node) - 4));
+ } else {
+ int already_read, num, i, start;
struct nand_ecclayout ecclayout;
+ cleanmarker.totlen = cpu_to_je32(8);
+ cleanmarker.hdr_crc = cpu_to_je32(crc32(0, &cleanmarker, sizeof(struct jffs2_unknown_node) - 4));
+
if (ioctl(fd, ECCGETLAYOUT, &ecclayout) != 0) {
fprintf(stderr, "%s: %s: unable to get NAND oob layout\n",
exe_name, mtd_device);
return 1;
}
-
- /* Get the position of the free bytes */
- if (!ecclayout.oobfree[0].length) {
- fprintf(stderr, " Eeep. Autoplacement selected and no empty space in oob\n");
- return 1;
+ already_read = 0;
+ for (i = 0; (already_read < 8) && ecclayout.oobfree[i].length; i++) {
+ num = MIN(8 - already_read, ecclayout.oobfree[i].length);
+ start = ecclayout.oobfree[i].offset;
+ memcpy(oobbuf + start, (unsigned char *)&cleanmarker + already_read, num);
+ already_read += num;
}
- clmpos = ecclayout.oobfree[0].offset;
- clmlen = ecclayout.oobfree[0].length;
- if (clmlen > 8)
- clmlen = 8;
- cleanmarker.totlen = cpu_to_je32(8);
}
- cleanmarker.hdr_crc = cpu_to_je32 (crc32 (0, &cleanmarker, sizeof (struct jffs2_unknown_node) - 4));
}
for (erase.start = 0; erase.start < meminfo.size; erase.start += meminfo.erasesize) {
@@ -143,9 +145,9 @@ int main (int argc, char *argv[])
/* write cleanmarker */
if (isNAND) {
struct mtd_oob_buf oob;
- oob.ptr = (unsigned char *) &cleanmarker;
- oob.start = erase.start + clmpos;
- oob.length = clmlen;
+ oob.ptr = oobbuf;
+ oob.start = erase.start;
+ oob.length = meminfo.oobsize;
if (ioctl (fd, MEMWRITEOOB, &oob) != 0) {
fprintf(stderr, "\n%s: %s: MTD writeoob failure: %s\n", exe_name, mtd_device, strerror(errno));
continue;
--
1.5.4.3
next prev parent reply other threads:[~2010-02-03 2:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-03 2:56 Stanley.Miao
2010-02-03 2:56 ` [PATCH 1/5] clean up the legacy interfaces in nandwrite.c Stanley.Miao
2010-02-03 2:56 ` [PATCH 2/5] check if the start address is page-aligned Stanley.Miao
2010-02-03 2:56 ` [PATCH 3/5] Fix the bug of writing a yaffs2 image to NAND Stanley.Miao
2010-02-03 2:56 ` [PATCH 4/5] Discard the legacy interface MEMGETOOBSEL in flash_eraseall Stanley.Miao
2010-02-03 2:56 ` Stanley.Miao [this message]
2010-02-03 3:16 ` Mike Frysinger
2010-02-03 4:31 ` Re: stanley.miao
-- strict thread matches above, loose matches on Subject: below --
2010-02-03 4:45 Fix mtd-utils bugs Stanley.Miao
2010-02-03 4:45 ` [PATCH 1/5] clean up the legacy interfaces in nandwrite.c Stanley.Miao
2010-02-03 4:45 ` [PATCH 2/5] check if the start address is page-aligned Stanley.Miao
2010-02-03 4:45 ` [PATCH 3/5] Fix the bug of writing a yaffs2 image to NAND Stanley.Miao
2010-02-03 4:45 ` [PATCH 4/5] Discard the legacy interface MEMGETOOBSEL in flash_eraseall Stanley.Miao
2010-02-03 4:45 ` [PATCH 5/5] Place the cleanmarker in OOB area according to the mode MTD_OOB_AUTO Stanley.Miao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1265165796-24686-6-git-send-email-stanley.miao@windriver.com \
--to=stanley.miao@windriver.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.