All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Felipe Franciosi <felipe@nutanix.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
	QEMU Developers <qemu-devel@nongnu.org>,
	"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PULL 18/33] vhost-user-scsi: Introduce vhost-user-scsi host device
Date: Wed, 7 Jun 2017 14:22:24 -0400 (EDT)	[thread overview]
Message-ID: <1265195474.6852496.1496859744613.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <0281E149-DE28-4D6D-80E0-1132CAB8ABDB@nutanix.com>

> > How, since there is no synchronization point between the vhost-user
> > server on the source and the destination?
> 
> The idea is that the backend should both stop picking up new requests and
> also quiesce outstanding requests upon a GET_VRING_BASE vhost message.

This could be documented, but perhaps it's best to add a START_STOP
feature and message to the vhost-user protocol?

The feature then can be optional for vhost-user-net and mandatory for
vhost-user-scsi.  When this is done we can remove .unmigratable.

Thanks,

Paolo

> > 
> > Can you please send a version of your patch that uses .unmigratable?
> 
> Sure I can do that. We can work on the migration later on.
> 
> > 
> > I'll send a v6 that momentarily drops vhost-scsi, but I intend to
> > include it again in the next pull request.
> 
> Sounds good to me.
> 
> Felipe
> 
> > 
> > Thanks,
> > 
> > Paolo
> 
> 

  reply	other threads:[~2017-06-07 18:22 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-07 15:28 [Qemu-devel] [PULL v5 00/33] Misc patches for 2017-06-01 Paolo Bonzini
2017-06-07 15:28 ` [Qemu-devel] [PULL 18/33] vhost-user-scsi: Introduce vhost-user-scsi host device Paolo Bonzini
2017-06-07 15:37   ` Peter Maydell
2017-06-07 15:39     ` Felipe Franciosi
2017-06-07 15:47       ` Peter Maydell
2017-06-07 18:26         ` Felipe Franciosi
2017-06-07 16:21       ` Paolo Bonzini
2017-06-07 16:26         ` Felipe Franciosi
2017-06-07 18:22           ` Paolo Bonzini [this message]
2017-06-07 18:30             ` Michael S. Tsirkin
2017-06-07 18:56               ` Paolo Bonzini
2017-06-08  0:31                 ` Michael S. Tsirkin
2017-06-08 11:05                   ` Felipe Franciosi
2017-06-08 13:33                     ` Paolo Bonzini
  -- strict thread matches above, loose matches on Subject: below --
2017-06-07 13:55 [Qemu-devel] [PULL v4 00/33] Misc patches for 2017-06-01 Paolo Bonzini
2017-06-07 13:55 ` [Qemu-devel] [PULL 18/33] vhost-user-scsi: Introduce vhost-user-scsi host device Paolo Bonzini
2017-06-06 14:02 [Qemu-devel] [PULL v3 00/33] Misc patches for 2017-06-01 Paolo Bonzini
2017-06-06 14:02 ` [Qemu-devel] [PULL 18/33] vhost-user-scsi: Introduce vhost-user-scsi host device Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1265195474.6852496.1496859744613.JavaMail.zimbra@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=felipe@nutanix.com \
    --cc=mst@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.