All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Pallipadi, Venkatesh" <venkatesh.pallipadi@intel.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: "tglx@linutronix.de" <tglx@linutronix.de>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] HPET: Drop WARN_ON for mismatch on HPET CMP readback
Date: Thu, 04 Feb 2010 11:22:15 -0800	[thread overview]
Message-ID: <1265311335.16916.586.camel@localhost.localdomain> (raw)
In-Reply-To: <20100204191112.GA10135@basil.fritz.box>

On Thu, 2010-02-04 at 11:11 -0800, Andi Kleen wrote:
>  HPET: Drop WARN_ON for mismatch on HPET CMP readback
>     
>     At least one Intel chipset seems to always return a constant value
>     when reading back the HPET CMP register. This triggers the WARN_ON_ONCE
>     on each boot.

I don't know of chipset returning a constant value. Which chipset is
this one?
There is a chipset ICH9/10 errata where it returns a previous value,
instead of most recently written value. I had a patch for that here.

http://marc.info/?l=linux-kernel&m=125849385330302&w=2

I wanted to send out final patch with a pointer to ICH9/10 spec update
which describes the errata. But, look like that spec update hasn't
happened yet. As we found issue with atleast one chipset with this
warn_on, I would prefer retaining it, with a fix like above.

Thanks,
Venki



  reply	other threads:[~2010-02-04 19:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-04 19:11 [PATCH] HPET: Drop WARN_ON for mismatch on HPET CMP readback Andi Kleen
2010-02-04 19:22 ` Pallipadi, Venkatesh [this message]
2010-02-04 19:32   ` Andi Kleen
2010-02-04 19:40     ` Pallipadi, Venkatesh
2010-02-04 19:46       ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1265311335.16916.586.camel@localhost.localdomain \
    --to=venkatesh.pallipadi@intel.com \
    --cc=andi@firstfloor.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.