All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steven Whitehouse <swhiteho@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 1/4] gfs2: add IO submission trace points
Date: Fri, 05 Feb 2010 09:49:54 +0000	[thread overview]
Message-ID: <1265363394.2524.3.camel@localhost> (raw)
In-Reply-To: <1265348727-19347-2-git-send-email-dchinner@redhat.com>

Hi,

On Fri, 2010-02-05 at 16:45 +1100, Dave Chinner wrote:
> Useful for tracking down where specific IOs are being issued
> from.
> 
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
> ---
>  fs/gfs2/log.c        |    6 ++++++
>  fs/gfs2/lops.c       |    6 ++++++
>  fs/gfs2/trace_gfs2.h |   41 +++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 53 insertions(+), 0 deletions(-)
> 
> diff --git a/fs/gfs2/log.c b/fs/gfs2/log.c
> index 4511b08..bd26dff 100644
> --- a/fs/gfs2/log.c
> +++ b/fs/gfs2/log.c
> @@ -121,6 +121,7 @@ __acquires(&sdp->sd_log_lock)
>  			lock_buffer(bh);
>  			if (test_clear_buffer_dirty(bh)) {
>  				bh->b_end_io = end_buffer_write_sync;
> +				trace_gfs2_submit_bh(bh, WRITE_SYNC_PLUG, __func__);
>  				submit_bh(WRITE_SYNC_PLUG, bh);
This looks like it could be a generically useful function, I wonder if
it would be possible to do this directly in submit_bh, since we should
be able to use __builtin_return_address(0) to find out the origin of the
call?

Steve.




  reply	other threads:[~2010-02-05  9:49 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-05  5:45 [Cluster-devel] (no subject) Dave Chinner
2010-02-05  5:45 ` [Cluster-devel] [PATCH 1/4] gfs2: add IO submission trace points Dave Chinner
2010-02-05  9:49   ` Steven Whitehouse [this message]
2010-02-05  9:48     ` Christoph Hellwig
2010-02-05  5:45 ` [Cluster-devel] [PATCH 2/4] gfs2: ordered writes are backwards Dave Chinner
2010-02-05 10:02   ` Steven Whitehouse
2010-02-05 10:34     ` Dave Chinner
2010-02-05  5:45 ` [Cluster-devel] [PATCH 3/4] gfs2: ordered buffer writes are not sync Dave Chinner
2010-02-05 10:58   ` Steven Whitehouse
2010-02-05  5:45 ` [Cluster-devel] [PATCH 4/4] gfs2: introduce AIL lock Dave Chinner
2010-02-05 11:11   ` Steven Whitehouse
2010-02-06  2:34     ` Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1265363394.2524.3.camel@localhost \
    --to=swhiteho@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.