From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Skeggs Subject: Re: [PATCH 1/2] libdrm/nouveau: new optimized libdrm pushbuffer ABI Date: Mon, 08 Feb 2010 20:25:35 +1000 Message-ID: <1265624735.2495.0.camel@nisroch> References: <1264755205-21514-1-git-send-email-luca@luca-barbieri.com> <1265604380.25890.1.camel@nisroch> Reply-To: skeggsb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: nouveau-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Errors-To: nouveau-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org To: Luca Barbieri Cc: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org List-Id: nouveau.vger.kernel.org On Mon, 2010-02-08 at 10:04 +0100, Luca Barbieri wrote: > > IMO, the changes are good. However, DRM_NOUVEAU_HEADER_PATCHLEVEL is > > used to indicate the version of the kernel interface that's supported, > > and not the libdrm API version. > > OK. > > Perhaps it would be useful to add a libdrm API version number as well? Other drivers use the libdrm version number itself, which we'll also start doing once we have a stable kernel API and are doing releases. Ben.