From: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
To: git@vger.kernel.org,
"João Carlos Mendes Luís" <jonny@jonny.eng.br>,
"Junio C Hamano" <gitster@pobox.com>,
"Johannes Sixt" <j6t@kdbg.org>
Cc: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Subject: [PATCH 1/4] make_absolute_path(): Do not append redundant slash
Date: Wed, 10 Feb 2010 00:02:27 +0700 [thread overview]
Message-ID: <1265734950-15145-1-git-send-email-pclouds@gmail.com> (raw)
make_absolute_path("foo") at root returns "//foo". This patch makes it
return "/foo" correctly.
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
---
.. so that "git init" will show "initialized empty Git in /.git"
abspath.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/abspath.c b/abspath.c
index b88122c..e72aede 100644
--- a/abspath.c
+++ b/abspath.c
@@ -54,8 +54,9 @@ const char *make_absolute_path(const char *path)
if (len + strlen(last_elem) + 2 > PATH_MAX)
die ("Too long path name: '%s/%s'",
buf, last_elem);
- buf[len] = '/';
- strcpy(buf + len + 1, last_elem);
+ if (*buf != '/' || buf[1] != '\0')
+ buf[len++] = '/';
+ strcpy(buf + len, last_elem);
free(last_elem);
last_elem = NULL;
}
--
1.7.0.rc2.182.g3adef
next reply other threads:[~2010-02-09 17:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-09 17:02 Nguyễn Thái Ngọc Duy [this message]
2010-02-09 17:02 ` [PATCH 2/4] rev-parse: make --git-dir return /.git instead of //.git Nguyễn Thái Ngọc Duy
2010-02-09 19:18 ` Johannes Sixt
2010-02-11 10:07 ` Nguyen Thai Ngoc Duy
2010-02-09 17:02 ` [PATCH 3/4] Support working directory located at root Nguyễn Thái Ngọc Duy
2010-02-09 19:19 ` Johannes Sixt
2010-02-11 12:44 ` Nguyen Thai Ngoc Duy
2010-02-09 17:02 ` [PATCH 4/4] Add test for using Git at root of file system Nguyễn Thái Ngọc Duy
2010-02-10 13:10 ` João Carlos Mendes Luís
2010-02-11 10:01 ` Nguyen Thai Ngoc Duy
2010-02-09 19:10 ` [PATCH 1/4] make_absolute_path(): Do not append redundant slash Johannes Sixt
2010-02-11 10:00 ` Nguyen Thai Ngoc Duy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1265734950-15145-1-git-send-email-pclouds@gmail.com \
--to=pclouds@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
--cc=jonny@jonny.eng.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.