All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
	Simon Raffeiner <sturmflut@lieberbiber.de>,
	Andrey Yurovsky <andrey@cozybit.com>,
	Javier Cardona <javier@cozybit.com>
Subject: Re: [PATCH] nl80211: does not allow NEW_STATION and DEL_STATION for mesh
Date: Fri, 12 Feb 2010 13:49:53 +0100	[thread overview]
Message-ID: <1265978993.15701.0.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1265978241-1601-1-git-send-email-cascardo@holoscopio.com>

[-- Attachment #1: Type: text/plain, Size: 1263 bytes --]

On Fri, 2010-02-12 at 10:37 -0200, Thadeu Lima de Souza Cascardo wrote:
> As discussed in linux-wireless mailint list, adding and removing
> stations for mesh topologies is not necessary. Since doing it triggers
> bugs, the sugestion was to simply disable it.
> 
> Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
> Cc: Johannes Berg <johannes@sipsolutions.net>
> Cc: Simon Raffeiner <sturmflut@lieberbiber.de>
> Cc: Andrey Yurovsky <andrey@cozybit.com>
> Cc: Javier Cardona <javier@cozybit.com>
> ---
>  net/wireless/nl80211.c |   47
> +++++++++++------------------------------------
>  1 files changed, 11 insertions(+), 36 deletions(-)
> 
> diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
> index 5b79ecf..176b8fe 100644
> --- a/net/wireless/nl80211.c
> +++ b/net/wireless/nl80211.c
> @@ -2001,6 +2001,10 @@ static int nl80211_new_station(struct sk_buff
> *skb, struct genl_info *info)
>  
>  	memset(&params, 0, sizeof(params));
>  
> +	if (dev->ieee80211_ptr->iftype != NL80211_IFTYPE_AP &&
> +	    dev->ieee80211_ptr->iftype != NL80211_IFTYPE_AP_VLAN)
> +		return -EINVAL;
> +
>  	if (!info->attrs[NL80211_ATTR_MAC])
>  		return -EINVAL;

You clearly didn't ever try this code.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

  reply	other threads:[~2010-02-12 12:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-12 12:37 [PATCH] nl80211: does not allow NEW_STATION and DEL_STATION for mesh Thadeu Lima de Souza Cascardo
2010-02-12 12:49 ` Johannes Berg [this message]
2010-02-12 13:55   ` Thadeu Lima de Souza Cascardo
2010-02-12 14:03     ` Johannes Berg
2010-02-12 14:34 ` [PATCH v2] " Thadeu Lima de Souza Cascardo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1265978993.15701.0.camel@jlt3.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=andrey@cozybit.com \
    --cc=cascardo@holoscopio.com \
    --cc=javier@cozybit.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=sturmflut@lieberbiber.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.